feat: typescript #705
Open
feat: typescript #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
types
branch
6 times, most recently
from
241fd44 to
72bc186
Compare
Also: - test: complete coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Provide TypeScript support for
espree.What changes did you make? (Give an overview)
checkJs/allowJsTypeScript toespree.lib/espree.js, removes an uncovered and apparently unnecessary branch (previously lines 152-154) where a property was being added to an array.Related Issues
A renewed approach to #544 which doesn't require a special, fragile build routine or non-standard JSDoc tags.
Is there anything you'd like reviewers to focus on?
The
@typedefexports that were of previous concern should not be here since the main file does not use them except for public type exports. Otherwise, we are using@import.Has some added complexity in redefining Acorn/acorn-jsx because Acorn's TypeScript does not concern all properties of relevance to plugin authors. See acornjs/acorn#1404 .
Currently applies acorn-jsx from my own fork as waiting on acornjs/acorn-jsx#139 .