Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add Node.js v23 #44

Merged
merged 3 commits into from
Oct 26, 2024
Merged

ci: add Node.js v23 #44

merged 3 commits into from
Oct 26, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

CI

What changes did you make? (Give an overview)

Add Node.js v23 environment

Related Issues

No

Is there anything you'd like reviewers to focus on?

No

fasttime
fasttime previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! But there are other checks failing. We should fix those problems first I think.

UPDATE: It seems that the CI build will be fixed when #42 is merged.

@amareshsm
Copy link
Member

LGTM, thanks! But there are other checks failing. We should fix those problems first I think.

In local I am not getting errors. I check in the node v20 and 22.

@fasttime
Copy link
Member

In local I am not getting errors. I check in the node v20 and 22.

I am getting errors locally after deleting node_modules and running npm install again and then npm run build.

@amareshsm
Copy link
Member

In local I am not getting errors. I check in the node v20 and 22.

I am getting errors locally after deleting node_modules and running npm install again and then npm run build.

ya, I am also getting errors after deleting and installing node_modules.

nzakas
nzakas reviewed Oct 25, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@snitin315
Copy link
Contributor Author

@fasttime @nzakas Done!

mdjermanovic
mdjermanovic approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 93d7861 into main Oct 26, 2024
15 checks passed
@mdjermanovic mdjermanovic deleted the snitin315-patch-1 branch October 26, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas left review comments

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@fasttime fasttime fasttime left review comments

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snitin315 @amareshsm @fasttime @nzakas @mdjermanovic