fix: expose plugin.configs in types
#59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
honestly, that's a clever fix. Was trying to figure out myself how to best approach this, but this is simple yet powerful and seems to get the job done. Haven't tested but looks like it should work |
nzakas
reviewed
Nov 13, 2024
| configs: { | ||
| recommended: { | ||
| plugins: { | ||
| get json() { |
There was a problem hiding this comment.
I'm not sure we want to change this into a getter. We're essentially replacing a property lookup with a function call on a key that is retrieved a lot during config calculation.
Maybe we could leave plugins as an empty object here and just assign json into the object later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Refactor code to fix the types
What changes did you make? (Give an overview)
This PR fixes the tsc-generated type of
plugin.configs. It does so by moving theconfigsobject into theplugindeclaration rather that assigning its fields in a separate step. I'm using a getter to cyclically referencepluginasplugin.configs.recommended.plugins.json.Related Issues
fixes #52
Is there anything you'd like reviewers to focus on?
There are currently no type tests in this plugin. Shall we add some type tests as part of this PR?