Skip to content

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Nov 20, 2024

Prerequisites checklist

What is the purpose of this pull request?

Adds a new no-unnormalized-keys rule.

What changes did you make? (Give an overview)

Ported over from #38.

  • Ensured that the rule is exported from the plugin
  • Updated README
  • Switched rule options to be an object with a named propert
  • Updated tests

Related Issues

Fixes #32
Closes #38

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Member Author

nzakas commented Nov 20, 2024

I think I got all of the outstanding work for this rule.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit c57882e into main Nov 23, 2024
16 checks passed
@mdjermanovic mdjermanovic deleted the issue32 branch November 23, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

New rule: Normalize string keys

4 participants