Add missing code for SERVER_ERROR handling under HAVE_SSL#1835
Merged
bmah888 merged 1 commit intoesnet:masterfrom May 2, 2025
Merged
Conversation
bmah888
changed the title
bmah888
approved these changes
Apr 25, 2025
Contributor
bmah888
left a comment
bmah888
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is definitely an error/omission. I'm not sure why the bug didn't result in the client blowing up somehow, but maybe the client was going to error-exit in this situation anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): none
Brief description of code changes (suitable for use as a commit message):
When
test_is_authorized(test)fails (underHAVE_SSL) andSERVER_ERRORstate is set, the code for sendingerrnoto the client is missing.