Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adc): make AdcConfig operators static #110

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix(adc): make AdcConfig operators static #110

merged 1 commit into from
Sep 26, 2023

Conversation

finger563
Copy link
Contributor

Description

Motivation and Context

Fixes multiple definition issue when using ADC component in some cases.

How has this been tested?

Building in a project which exhibited the error and then using this fix to fix it.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Example of the error:
CleanShot 2023-09-26 at 11 07 38

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added bug Something isn't working adc labels Sep 26, 2023
@finger563 finger563 merged commit 2e0ac37 into main Sep 26, 2023
39 checks passed
@finger563 finger563 deleted the bugfix/adc branch September 26, 2023 16:10
SamAtBackbone added a commit to SamAtBackbone/espp that referenced this pull request Sep 26, 2023
fix(adc): make AdcConfig operators static (esp-cpp#110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adc bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant