Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color): add converting assignment operator for Rgb <-> Hsv #297

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jul 30, 2024

Description

  • Add assignment operator to espp::Rgb and espp::Hsv to allow converting assignment between the two
  • Add color_code static methods for generating color code from rgb and hsv values.

Motivation and Context

Simplifies API / use of Rgb and Hsv color classes.

How has this been tested?

Building and running the color example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-07-30 at 10 29 50

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jul 30, 2024
@finger563 finger563 added enhancement New feature or request color labels Jul 30, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 07f4eff into main Jul 30, 2024
63 checks passed
@finger563 finger563 deleted the feature/color-assignment-conversion branch July 30, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant