fix(ble_gatt_server): Deinit services before device deinit #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BleGattServer::client_
connection info is cleared, so that it does not improperly think that it is still connected when it may not be.BleGattServer::deinit
to deinit the services before the stackNimBLEDevice::deinit(true)
.ble_gatt_server/example
to runBleGattServer::deinit
BleGattServer
so thatinit()
anddeinit()
can be called multiple times in a row without causing a crashble_gatt_server/example
to test calling deinit multiple times (once manually and once via destructor)Motivation and Context
Ensures deinit works properly and does not cause any crashes.
How has this been tested?
Building and running the updated example, showing no crash.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
After the change (fixed):
no clients were ever connected, then deinit:
client was connected, then deinit:
Before the change:
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.