Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adc): Add mutex ensuring OneshotAdc can be used safely from multiple threads #338

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Add mutex to OneshotAdc APIs
  • Remove warning in continuous ADC

Motivation and Context

Ensures that the oneshot adc can safely be used from multiple threads

How has this been tested?

Building and running adc/example on a QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-10-23 at 08 35 01

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added the adc label Oct 23, 2024
@finger563 finger563 self-assigned this Oct 23, 2024
@finger563 finger563 changed the title fix(adc): Add mutex to oneshot adc public APIs feat(adc): Add mutex ensuring OneshotAdc can be used safely from multiple threads Oct 23, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 58a8c25 into main Oct 23, 2024
69 checks passed
@finger563 finger563 deleted the fix/oneshot-adc-mutex branch October 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant