unstabilize Uart::split, globally remove _bytes postfix
#3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync variant), unify read/write logic for inherent impls and trait impls
bugadani
reviewed
Feb 14, 2025
MabezDev
force-pushed
the
remove-bytes-postfix
branch
from
e273350 to
a6fcdd3
Compare
MabezDev
force-pushed
the
remove-bytes-postfix
branch
from
a6fcdd3 to
7d19cf6
Compare
bugadani
reviewed
Feb 14, 2025
bugadani
reviewed
Feb 14, 2025
bugadani
reviewed
Feb 14, 2025
| ## UART changes | ||
|
|
||
| Uart `write_bytes` is now blocking and return the number of bytes written. `read_bytes` will block until it fills the provided buffer with received bytes, use `read_buffered_bytes` to read the available bytes without blocking. | ||
| Uart `write_bytes` is now blocking and return the number of bytes written. `read_bytes` will block until it fills at least one byte into the buffer with received bytes, use `read_buffered_bytes` to read the available bytes without blocking. |
There was a problem hiding this comment.
These were renamed, right?
bugadani
reviewed
Feb 14, 2025
| @@ -120,8 +120,8 @@ impl crate::interrupt::InterruptConfigurable for Sha<'_> { | |||
| } | |||
|
|
|||
| // A few notes on this implementation with regards to 'memcpy', | |||
| // - It seems that ptr::write_bytes already acts as volatile, while ptr::copy_* | |||
| // does not (in this case) | |||
| // - It seems that ptr::write already acts as volatile, while ptr::copy_* does | |||
There was a problem hiding this comment.
I'd probably just remove this line completely. ptr::write is not volatile access, regardless of how it acts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
This PR removes the postfix
_byteswhereever the input parameter was a byte slice. This leaves us with the common case ofwrite == bytes, and gives us scope to addwrite_words,write_bitsetc in the future.It also unstabilizes
Uart::splitthe the different halfs respectively.