Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump monaco-editor from 0.34.1 to 0.52.0 #654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Bumps monaco-editor from 0.34.1 to 0.52.0.

Release notes

Sourced from monaco-editor's releases.

v0.52.0

Changes:

  • #4691: Prepare monaco-editor for release 0.52
  • #4665: Updates nvm to align with vscode nvm file.
  • #4652: Removing editor.main.nls.js

This list of changes was auto generated.

v0.52.0-rc2

Changes:

  • #4665: Updates nvm to align with vscode nvm file.
  • #4652: Removing editor.main.nls.js

This list of changes was auto generated.

v0.51.0

Changes:

  • #4649: Add changes for monaco editor release 0.51.0
  • #4630: Remove locker and info-needed-closer workflows.
  • #4573: Adding some detail in MAINTAINING.md for trigger build step
  • #4586: Update Q# Keywords

This list of changes was auto generated.

v0.51.0-rc3

No release notes provided.

v0.51.0-rc2

No release notes provided.

v0.51.0-rc

No release notes provided.

v0.51.0-dev-20240807

No release notes provided.

v0.51.0-dev-20240806

No release notes provided.

v0.51.0-dev-20240805

No release notes provided.

... (truncated)

Changelog

Sourced from monaco-editor's changelog.

[0.52.0]

  • Comment added inside of IModelContentChangedEvent

[0.51.0]

  • New fields IEditorOptions.placeholder and IEditorOptions.compactMode
  • New fields IGotoLocationOptions.multipleTests and IGotoLocationOptions.alternativeTestsCommand
  • New field IInlineEditOptions.backgroundColoring
  • New experimental field IEditorOptions.experimental.useTrueInlineView
  • New options CommentThreadRevealOptions for comments

Contributions to monaco-editor:

[0.50.0]

  • New field IEditorMinimapOptions.sectionHeaderLetterSpacing
  • New field IOverlayWidgetPosition.stackOridinal
  • New field EmitOutput.diagnostics
  • New event IOverlayWidget.onDidLayout
  • New events ICodeEditor.onBeginUpdate and ICodeEditor.onEndUpdate
  • HoverVerbosityRequest.action -> HoverVerbosityRequest.verbosityDelta
  • MultiDocumentHighlightProvider.selector changed from LanguageFilter to LanguageSelector
  • New optional parameters in getEmitOutput: emitOnlyDtsFiles and forceDtsEmit

Contributions to monaco-editor:

[0.49.0]

  • New proposed editorHoverVerbosityLevel API
  • New proposed newSymbolNamesProvider API

Contributions to monaco-editor:

[0.48.0]

Additions

  • Various bug fixes
  • Minimap Section Headers (see config option showRegionSectionHeaders)
  • Diff Editor Gutter Menu (see config option renderGutterMenu)

... (truncated)

Commits
  • f6dc0eb Merge pull request #4691 from microsoft/chubby-cardinal
  • 53e8e1c adding changelog md change
  • 7959d5c update pacakge.json
  • 3c7eb57 undo the package upgrade change
  • f262e8f Defines setInterval/setTimeout on faked globalThis in unit test
  • b31d22b Updates nvm to align with vscode nvm file. (#4665)
  • b8a83d5 Merge pull request #4652 from microsoft/annoyed-dragon
  • e52ff42 removing editor.main.nls.js
  • 67d664a Merge pull request #4649 from microsoft/unique-locust
  • 88c558b adding changes for monaco editor release
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by vscode-bot, a new releaser for monaco-editor since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [monaco-editor](https://github.com/microsoft/monaco-editor) from 0.34.1 to 0.52.0.
- [Release notes](https://github.com/microsoft/monaco-editor/releases)
- [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md)
- [Commits](microsoft/monaco-editor@v0.34.1...v0.52.0)

---
updated-dependencies:
- dependency-name: monaco-editor
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 23, 2024
@swoboda1337
Copy link
Contributor

This should be fixed after #657, should rerun checks

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 9, 2024

A newer version of monaco-editor exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@HHHartmann
Copy link

As far as I can see this PR does effectively only contain the stuff from dependabot. So could this PR be closed so that depandabot can create a new one with the current version of monaco-editor?

Btw is there a reason why the editor is not updated? The last few dependabot PRs were not merged.

@swoboda1337
Copy link
Contributor

swoboda1337 commented Jan 5, 2025

As far as I can see this PR does effectively only contain the stuff from dependabot. So could this PR be closed so that depandabot can create a new one with the current version of monaco-editor?

Btw is there a reason why the editor is not updated? The last few dependabot PRs were not merged.

Not sure why the editor is so far behind, it really needs to be updated. The current version 0.34.1 was released in Oct 2022. My #687 depends on it and you noticed issues on Android.

This PR was failing for a while but was manually rerun after a fix so dependabot won't refresh it. Can merge this one and dependabot will create a new one whenever it checks again.

@jesserockz this is in reference to a discord discussion: https://discordapp.com/channels/429907082951524364/429907082955718657/1322282309361336350

@swoboda1337
Copy link
Contributor

@balloob you were the last one to upgrade monaco-editor in 2022: #340

Any reason we have stopped merging updates? I don't see any comments in any of the PRs. Could we get it updated? See the comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants