add m5stack atom-s3u pindefs #11352

mhaberler · 2025-05-11T19:40:35Z

Description of Change

add M5Stack AromS3U pin definitions as per https://docs.m5stack.com/en/core/AtomS3U

CLAassistant · 2025-05-11T19:40:40Z

All committers have signed the CLA.

github-actions · 2025-05-11T19:41:10Z

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello mhaberler, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f499d99

matches with espressif/arduino-esp32#11352

matches pindefs PR espressif/arduino-esp32#11352

* feat(boards): add m5stack-atoms3u board matches pindefs PR espressif/arduino-esp32#11352

P-R-O-C-H-Y · 2025-05-12T06:44:53Z

Hi @mhaberler, you are missing board definitions in boards.txt file. You need to add that also in order to be possible to select the board.

mhaberler · 2025-05-12T07:36:56Z

Hi @mhaberler, you are missing board definitions in boards.txt file. You need to add that also in order to be possible to select the board.

thanks, will do

P-R-O-C-H-Y · 2025-05-12T08:26:05Z

Also please don't forget to sign the CLA

extend boards.txt as per https://docs.m5stack.com/en/core/AtomS3U Signed-off-by: Michael Haberler <[email protected]>

mhaberler · 2025-05-12T11:25:19Z

Also please don't forget to sign the CLA

did that, succeeded, re-pushed with signed-off-by, CLA still looks unsigned in PR
please advis

mhaberler · 2025-05-13T12:03:44Z

well I dont know how to get past this CLA issue

I herewith certify I did sign the CLA for espressif/arduino-esp32 Version: 2023-04-20

Please go ahead and merge.

P-R-O-C-H-Y · 2025-05-14T06:55:52Z

well I dont know how to get past this CLA issue

I herewith certify I did sign the CLA for espressif/arduino-esp32 Version: 2023-04-20

Please go ahead and merge.

"Michael Haberler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account."

I see there are few commits that were committed with just a user name without an GitHub account.
Can you please redo your changes (close/reopen the PR if needed) that all commits comes from your GH account @mhaberler.
Thanks

mhaberler · 2025-05-14T11:53:17Z

sorry about that. Will redo properly.

P-R-O-C-H-Y

@mhaberler PTAL

P-R-O-C-H-Y · 2025-05-15T11:17:59Z

boards.txt

+m5stack_atoms3u.menu.FlashMode.opi=OPI 80MHz
+m5stack_atoms3u.menu.FlashMode.opi.build.flash_mode=dout
+m5stack_atoms3u.menu.FlashMode.opi.build.boot=opi
+m5stack_atoms3u.menu.FlashMode.opi.build.boot_freq=80m
+m5stack_atoms3u.menu.FlashMode.opi.build.flash_freq=80m


S3FN8 has quad SPI flash

Suggested change

m5stack_atoms3u.menu.FlashMode.opi=OPI 80MHz

m5stack_atoms3u.menu.FlashMode.opi.build.flash_mode=dout

m5stack_atoms3u.menu.FlashMode.opi.build.boot=opi

m5stack_atoms3u.menu.FlashMode.opi.build.boot_freq=80m

m5stack_atoms3u.menu.FlashMode.opi.build.flash_freq=80m

P-R-O-C-H-Y · 2025-05-15T11:19:58Z

boards.txt

+m5stack_atoms3u.menu.PSRAM.disabled=Disabled
+m5stack_atoms3u.menu.PSRAM.disabled.build.defines=
+m5stack_atoms3u.menu.PSRAM.disabled.build.psram_type=qspi
+m5stack_atoms3u.menu.PSRAM.enabled=QSPI PSRAM
+m5stack_atoms3u.menu.PSRAM.enabled.build.defines=-DBOARD_HAS_PSRAM
+m5stack_atoms3u.menu.PSRAM.enabled.build.psram_type=qspi
+m5stack_atoms3u.menu.PSRAM.opi=OPI PSRAM
+m5stack_atoms3u.menu.PSRAM.opi.build.defines=-DBOARD_HAS_PSRAM
+m5stack_atoms3u.menu.PSRAM.opi.build.psram_type=opi


Are you sure the board have PSRAM?

P-R-O-C-H-Y · 2025-05-15T11:21:08Z

boards.txt

+m5stack_atoms3u.menu.UploadMode.default=UART0 / Hardware CDC
+m5stack_atoms3u.menu.UploadMode.default.upload.use_1200bps_touch=false
+m5stack_atoms3u.menu.UploadMode.default.upload.wait_for_upload_port=false
+m5stack_atoms3u.menu.UploadMode.cdc=USB-OTG CDC (TinyUSB)
+m5stack_atoms3u.menu.UploadMode.cdc.upload.use_1200bps_touch=true
+m5stack_atoms3u.menu.UploadMode.cdc.upload.wait_for_upload_port=true


The board have only 1 connector (USB), please use only proper settings, also with other stuff like CDC and USB mode

give me a few days

I need to install Arduino IDE which I havent used in years, and verify

mhaberler force-pushed the master branch from f496672 to cfbbde8 Compare May 11, 2025 19:44

mhaberler added a commit to mhaberler/platform-espressif32 that referenced this pull request May 11, 2025

feat(boards): add m5stack-atoms3u board support

28d86fb

matches with espressif/arduino-esp32#11352

mhaberler added a commit to mhaberler/platform-espressif32 that referenced this pull request May 11, 2025

feat(boards): add m5stack-atoms3u board

2b92585

matches pindefs PR espressif/arduino-esp32#11352

mhaberler mentioned this pull request May 11, 2025

feat(boards): add m5stack-atoms3u board pioarduino/platform-espressif32#172

Merged

4 tasks

Jason2866 pushed a commit to pioarduino/platform-espressif32 that referenced this pull request May 11, 2025

feat(boards): add m5stack-atoms3u board (#172)

73d51dd

* feat(boards): add m5stack-atoms3u board matches pindefs PR espressif/arduino-esp32#11352

P-R-O-C-H-Y added the Type: 3rd party Boards label May 12, 2025

P-R-O-C-H-Y added the Status: In Progress ⚠️ Issue is in progress label May 12, 2025

mhaberler force-pushed the master branch from cfbbde8 to 01f62d9 Compare May 12, 2025 10:55

feat(esp32s3): m5stack atom-s3u pindefs

481f5bc

extend boards.txt as per https://docs.m5stack.com/en/core/AtomS3U Signed-off-by: Michael Haberler <[email protected]>

mhaberler force-pushed the master branch from 01f62d9 to 481f5bc Compare May 12, 2025 11:00

Merge branch 'master' into master

f499d99

P-R-O-C-H-Y requested changes May 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add m5stack atom-s3u pindefs #11352

add m5stack atom-s3u pindefs #11352

mhaberler commented May 11, 2025

CLAassistant commented May 11, 2025 •

edited

Loading

github-actions bot commented May 11, 2025 •

edited

Loading

P-R-O-C-H-Y commented May 12, 2025

mhaberler commented May 12, 2025

P-R-O-C-H-Y commented May 12, 2025

mhaberler commented May 12, 2025

mhaberler commented May 13, 2025

P-R-O-C-H-Y commented May 14, 2025

mhaberler commented May 14, 2025

P-R-O-C-H-Y left a comment

P-R-O-C-H-Y May 15, 2025

P-R-O-C-H-Y May 15, 2025

P-R-O-C-H-Y May 15, 2025

mhaberler May 15, 2025

add m5stack atom-s3u pindefs #11352

Are you sure you want to change the base?

add m5stack atom-s3u pindefs #11352

Conversation

mhaberler commented May 11, 2025

Description of Change

CLAassistant commented May 11, 2025 • edited Loading

github-actions bot commented May 11, 2025 • edited Loading

P-R-O-C-H-Y commented May 12, 2025

mhaberler commented May 12, 2025

P-R-O-C-H-Y commented May 12, 2025

mhaberler commented May 12, 2025

mhaberler commented May 13, 2025

P-R-O-C-H-Y commented May 14, 2025

mhaberler commented May 14, 2025

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y May 15, 2025

Choose a reason for hiding this comment

P-R-O-C-H-Y May 15, 2025

Choose a reason for hiding this comment

P-R-O-C-H-Y May 15, 2025

Choose a reason for hiding this comment

mhaberler May 15, 2025

Choose a reason for hiding this comment

CLAassistant commented May 11, 2025 •

edited

Loading

github-actions bot commented May 11, 2025 •

edited

Loading