Skip to content

refactor(ble): minor BLE library cleanup #11789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

refactor(ble): minor BLE library cleanup #11789

merged 3 commits into from
Sep 10, 2025

Conversation

Kolcha
Copy link
Contributor

@Kolcha Kolcha commented Sep 3, 2025

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

minor BLE library cleanup:

  • made many getters const (as it supposed to be)
  • pass string by reference in modified classes
  • other random code cleanup / fixes

Test Scenarios

I have tested my Pull Request on Arduino-esp32 core v3.3.0 with ESP32. Successful build is enough to confirm that everything is ok.

Related links

nothing

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Kolcha, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3c31d67

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Test Results

 76 files   76 suites   14m 28s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 3c31d67.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5💚 -38⚠️ +20.000.00000.000.00
ESP32S3💚 -12⚠️ +240.000.00000.000.00
ESP32C3💚 -38⚠️ +2💚 -0.010.00000.000.00
ESP32C6💚 -38⚠️ +2💚 -0.010.00000.000.00
ESP32H2💚 -38⚠️ +2💚 -0.010.00000.000.00
ESP32💚 -16⚠️ +280.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Beacon_Scanner💚 -380💚 -120💚 -380💚 -380💚 -380💚 -160
libraries/BLE/examples/Client⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Client_secure_static_passkey⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/EddystoneTLM_Beacon⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/EddystoneURL_Beacon⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Notify⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Scan⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Server⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +280
libraries/BLE/examples/Server_multiconnect⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Server_secure_static_passkey⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/UART⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/Write⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240
libraries/BLE/examples/iBeacon⚠️ +20⚠️ +240⚠️ +20⚠️ +20⚠️ +20⚠️ +240

@lucasssvaz
Copy link
Member

Could you rebase your PR with the latest BLE changes ?

@Kolcha
refactor(ble): minor BLE library cleanup
9946a98 
- made many getters `const` (as it supposed to be)
- pass string by reference in modified classes
- other random code cleanup / fixes
@Kolcha
Copy link
Contributor Author

Kolcha commented Sep 8, 2025

rebased

SuGlider
SuGlider approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Kolcha for the contribution!

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged Area: BLE Issues related to BLE labels Sep 9, 2025
@SuGlider SuGlider moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Sep 9, 2025
@SuGlider SuGlider added this to the 3.3.0 milestone Sep 9, 2025
@me-no-dev me-no-dev merged commit a39d1bd into espressif:master Sep 10, 2025
55 checks passed
@Kolcha Kolcha deleted the ble-cleanup branch September 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@SuGlider SuGlider SuGlider approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Area: BLE Issues related to BLE Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kolcha @lucasssvaz @SuGlider @me-no-dev