Skip to content

Conversation

lucasssvaz
Copy link
Member

Description of Change

Add support for NimBLE in SimpleBLE

Test Scenarios

Tested locally.

@lucasssvaz lucasssvaz self-assigned this Sep 10, 2025
@lucasssvaz lucasssvaz requested a review from a team as a code owner September 10, 2025 12:19
@lucasssvaz lucasssvaz added the Area: BLE Issues related to BLE label Sep 10, 2025
Copy link
Contributor

github-actions bot commented Sep 10, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(simpleBLE): Add support for NimBLE":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "feat/simpleBLE_nimble" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f4bb3ae

Copy link
Contributor

github-actions bot commented Sep 10, 2025

Test Results

 76 files   76 suites   13m 12s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit f4bb3ae.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 10, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +1360.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Beacon_Scanner0000--00000000
libraries/BLE/examples/Client0000--00000000
libraries/BLE/examples/Client_secure_static_passkey0000--00000000
libraries/BLE/examples/EddystoneTLM_Beacon0000--00000000
libraries/BLE/examples/EddystoneURL_Beacon0000--00000000
libraries/BLE/examples/Notify0000--00000000
libraries/BLE/examples/Scan0000--00000000
libraries/BLE/examples/Server0000--00000000
libraries/BLE/examples/Server_multiconnect0000--00000000
libraries/BLE/examples/Server_secure_static_passkey0000--00000000
libraries/BLE/examples/UART0000--00000000
libraries/BLE/examples/Write0000--00000000
libraries/BLE/examples/iBeacon0000--00000000
libraries/RainMaker/examples/RMakerCustom0000000000----
libraries/RainMaker/examples/RMakerCustomAirCooler0000000000----
libraries/RainMaker/examples/RMakerSonoffDualR30000000000----
libraries/RainMaker/examples/RMakerSwitch0000000000----
libraries/WiFiProv/examples/WiFiProv0000000000--00
libraries/BluetoothSerial/examples/DiscoverConnect------------00
libraries/BluetoothSerial/examples/GetLocalMAC------------00
libraries/BluetoothSerial/examples/SerialToSerialBT------------00
libraries/BluetoothSerial/examples/SerialToSerialBTM------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_Legacy------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_SSP------------00
libraries/BluetoothSerial/examples/bt_classic_device_discovery------------00
libraries/BluetoothSerial/examples/bt_remove_paired_devices------------00
libraries/SimpleBLE/examples/SimpleBleDevice------------⚠️ +1360

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for NimBLE in the SimpleBLE library, expanding beyond the existing Bluedroid-only support. The changes enable the SimpleBLE library to work with both BLE stacks (Bluedroid and NimBLE) and add support for ESP-Hosted configurations.

Key changes:

  • Extended conditional compilation to support both Bluedroid and NimBLE BLE stacks
  • Added complete NimBLE implementation with initialization, callbacks, and advertising functions
  • Updated example to use generic BOOT_PIN instead of hardcoded pin 0
  • Added deprecation warning to BluetoothSerial class

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
SimpleBLE.h Updated header guards and includes to support both BLE stacks
SimpleBLE.cpp Added comprehensive NimBLE support with parallel implementation to Bluedroid
SimpleBleDevice.ino Updated example to use BOOT_PIN constant and removed Bluedroid-specific error check
BluetoothSerial.h Added deprecation attribute to the BluetoothSerial class

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Sep 11, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Sep 11, 2025
@me-no-dev me-no-dev merged commit ad18f5f into espressif:master Sep 11, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BLE Issues related to BLE Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants