-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(simpleBLE): Add support for NimBLE #11813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 13m 12s ⏱️ Results for commit f4bb3ae. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for NimBLE in the SimpleBLE library, expanding beyond the existing Bluedroid-only support. The changes enable the SimpleBLE library to work with both BLE stacks (Bluedroid and NimBLE) and add support for ESP-Hosted configurations.
Key changes:
- Extended conditional compilation to support both Bluedroid and NimBLE BLE stacks
- Added complete NimBLE implementation with initialization, callbacks, and advertising functions
- Updated example to use generic BOOT_PIN instead of hardcoded pin 0
- Added deprecation warning to BluetoothSerial class
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
SimpleBLE.h | Updated header guards and includes to support both BLE stacks |
SimpleBLE.cpp | Added comprehensive NimBLE support with parallel implementation to Bluedroid |
SimpleBleDevice.ino | Updated example to use BOOT_PIN constant and removed Bluedroid-specific error check |
BluetoothSerial.h | Added deprecation attribute to the BluetoothSerial class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description of Change
Add support for NimBLE in SimpleBLE
Test Scenarios
Tested locally.