Feature/hdmi #425
Open
Feature/hdmi #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
feature/hdmi
branch
6 times, most recently
from
5c04252
to
bea3856
Compare
There was a problem hiding this comment.
@espzav Thank you for this great feature! I left few formal nitpicks
| This BSP supports HDMI converter Lontium LT8912B. Follow these rules for using it with HDMI: | ||
| - Use ESP-IDF 5.4 or older (from commit [93fdbf2](https://github.com/espressif/esp-idf/commit/93fdbf25b3ea7e44d1f519ed61050847dcc8a076)) | ||
| - Only RGB888 is supported with HDMI | ||
| - Use MIPI-DSI to HDMI converter from this link ([Schematic](), [PCB]()) |
There was a problem hiding this comment.
Please add the links :)
There was a problem hiding this comment.
Sorry, I forgot remove it. I still haven't got permission for sharing it.
espzav
force-pushed
the
feature/hdmi
branch
2 times, most recently
from
84eabde
to
e6afa59
Compare
igrr
reviewed
Nov 6, 2024
igrr
reviewed
Nov 6, 2024
igrr
reviewed
Nov 6, 2024
igrr
reviewed
Nov 6, 2024
igrr
approved these changes
Nov 6, 2024
|
@igrr Thank you for the review. All comments was fixed or answered. |
igrr
reviewed
Nov 12, 2024
| ESP_LOGI(TAG, "HDMI configuration for 1280x800@60HZ"); | ||
| esp_lcd_dpi_panel_config_t dpi_config = LT8912B_1280x800_PANEL_60HZ_DPI_CONFIG(); | ||
| #elif CONFIG_BSP_LCD_HDMI_1920x1080_30HZ | ||
| ESP_LOGI(TAG, "HDMI configuration for 1280x800@30HZ"); |
There was a problem hiding this comment.
Suggested change
| ESP_LOGI(TAG, "HDMI configuration for 1280x800@30HZ"); | |
| ESP_LOGI(TAG, "HDMI configuration for 1920x1080@30HZ"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description