Skip to content

Fix secondary data dump, typos (AEGHB-1117) #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jetpax
Copy link

@jetpax jetpax commented Jun 20, 2025

Description

Unsolicited data on secondary interface was not dumped to terminal, just zeroes
eg with secondary interface set to interface 1 on SIM7600 (NMEA sentences every second), console dumps

I (31055) 4g_main: rssi=99, ber=99
I (31555) esp-modem-dte: Intf2 not handle date, just dump:
I (31555) esp-modem-dte: inf2: 0x3fcd0aa4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31561) esp-modem-dte: inf2: 0x3fcd0ab4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31572) esp-modem-dte: inf2: 0x3fcd0ac4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31582) esp-modem-dte: inf2: 0x3fcd0ad4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31593) esp-modem-dte: inf2: 0x3fcd0ae4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31604) esp-modem-dte: inf2: 0x3fcd0af4   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31615) esp-modem-dte: inf2: 0x3fcd0b04   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31626) esp-modem-dte: inf2: 0x3fcd0b14   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31637) esp-modem-dte: inf2: 0x3fcd0b24   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31648) esp-modem-dte: inf2: 0x3fcd0b34   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31658) esp-modem-dte: inf2: 0x3fcd0b44   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31669) esp-modem-dte: inf2: 0x3fcd0b54   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31680) esp-modem-dte: inf2: 0x3fcd0b64   00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
I (31691) esp-modem-dte: inf2: 0x3fcd0b74   00 00 00 00 00 00 00                              |.......|

Related

Testing

After fix, console dumps

I (40703) 4g_main: rssi=99, ber=99
I (41502) esp-modem-dte: Unsolicited data on secondary itf, dumping:
I (41502) esp-modem-dte: intf2: 0x3fcd0a74   24 47 4e 47 4e 53 2c 2c  2c 2c 2c 2c 4e 4e 4e 2c  |$GNGNS,,,,,,NNN,|
I (41509) esp-modem-dte: intf2: 0x3fcd0a84   2c 2c 2c 2c 2c 2a 31 44  0d 0a 24 47 50 56 54 47  |,,,,,*1D..$GPVTG|
I (41520) esp-modem-dte: intf2: 0x3fcd0a94   2c 2c 54 2c 2c 4d 2c 2c  4e 2c 2c 4b 2c 4e 2a 32  |,,T,,M,,N,,K,N*2|
I (41531) esp-modem-dte: intf2: 0x3fcd0aa4   43 0d 0a 24 47 50 47 53  41 2c 41 2c 31 2c 2c 2c  |C..$GPGSA,A,1,,,|
I (41542) esp-modem-dte: intf2: 0x3fcd0ab4   2c 2c 2c 2c 2c 2c 2c 2c  2c 2c 2c 2c 2c 2a 33 32  |,,,,,,,,,,,,,*32|
I (41552) esp-modem-dte: intf2: 0x3fcd0ac4   0d 0a 24 47 4e 47 53 41  2c 41 2c 31 2c 2c 2c 2c  |..$GNGSA,A,1,,,,|
I (41563) esp-modem-dte: intf2: 0x3fcd0ad4   2c 2c 2c 2c 2c 2c 2c 2c  2c 2c 2c 2c 2a 32 43 0d  |,,,,,,,,,,,,*2C.|
I (41574) esp-modem-dte: intf2: 0x3fcd0ae4   0a 24 42 44 47 53 41 2c  41 2c 31 2c 2c 2c 2c 2c  |.$BDGSA,A,1,,,,,|
I (41585) esp-modem-dte: intf2: 0x3fcd0af4   2c 2c 2c 2c 2c 2c 2c 2c  2c 2c 2a 30 46 0d 0a 24  |,,,,,,,,,,*0F..$|
I (41596) esp-modem-dte: intf2: 0x3fcd0b04   47 50 47 47 41 2c 2c 2c  2c 2c 2c 30 2c 2c 2c 2c  |GPGGA,,,,,,0,,,,|
I (41607) esp-modem-dte: intf2: 0x3fcd0b14   2c 2c 2c 2c 2a 36 36 0d  0a 24 50 51 58 46 49 2c  |,,,,*66..$PQXFI,|
I (41618) esp-modem-dte: intf2: 0x3fcd0b24   2c 2c 2c 2c 2c 2c 2c 2c  2c 2a 35 36 0d 0a 24 47  |,,,,,,,,,*56..$G|
I (41629) esp-modem-dte: intf2: 0x3fcd0b34   50 52 4d 43 2c 2c 56 2c  2c 2c 2c 2c 2c 2c 2c 2c  |PRMC,,V,,,,,,,,,|
I (41640) esp-modem-dte: intf2: 0x3fcd0b44   2c 4e 2a 35 33 0d 0a                              |,N*53..|


Checklist

Before submitting a Pull Request, please ensure the following:

  • [✓ ] 🚨 This PR does not introduce breaking changes.
  • [ ✓] All CI checks (GH Actions) pass.
  • [ ✓] Documentation is updated as needed.
  • [✓ ] Tests are updated or added as necessary.
  • [ ✓] Code is well-commented, especially in complex areas.
  • [ ✓] Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jun 20, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jetpax, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 180c651

@github-actions github-actions bot changed the title Fix secondary data dump, typos Fix secondary data dump, typos (AEGHB-1117) Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants