USB MSC: speed optimization #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
2 times, most recently
from
089fb6f
to
a466843
Compare
roma-jam
reviewed
May 22, 2023
Dazza0
reviewed
May 26, 2023
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
from
a466843
to
55fcd56
Compare
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
from
55fcd56
to
3a2a44f
Compare
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
2 times, most recently
from
dcdbe29
to
da0e56a
Compare
roma-jam
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Hey @tore-espressif ,
I have checked the code again and run error_recovery_1 and _2 locally.
Small comments only, otherwise LGTM.
esp-saurabhbansal
approved these changes
Jun 8, 2023
|
@tore-espressif Changes LGTM |
Dazza0
approved these changes
Jun 13, 2023
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
2 times, most recently
from
ef0257d
to
6928417
Compare
This will save CPU time when MSC driver has nothing to do
msc driver offered debug functions that accessed an array outside of its boundaries
The MSC driver can now only be used with the VFS component. The MSC driver will reuse an intermediate VFS buffer to send larger transfers to MSC device, dramatically increasing transfer speeds Expose SCSI commands as esp_private include" SCSI commands can be used for direct access of memory blocks
tore-espressif
force-pushed
the
usb/msc/speed_optimization
branch
from
6928417
to
f83def3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
After the application starts new USB transfer, the USB-OTG peripheral will schedule it for next frame (which can be as delayed as 1ms). Therefore, the application must submit large-enough (>1kB) transfers to fully leverage USB FullSpeed bandwidth. For larger USB transfers we need more DMA capable memory, plus we need the same amount for memory for buffer in Virtual File System.
This change reuses the VFS buffer for USB transfers, which saves memory and does not require any copying between buffers. Plus, the user gets a convenient API to change the buffer size per file with
setvbuf(), without any configuration of the MSC driver