Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] add swap_color_bytes for rgb888. (IEC-160) #369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix] add swap_color_bytes for rgb888. (IEC-160) #369

wants to merge 2 commits into from

Conversation

100312dog
Copy link

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

add swap_color_bytes for rgb888 to get pixels in rgb/bgr order.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title [fix] add swap_color_bytes for rgb888. [fix] add swap_color_bytes for rgb888. (IEC-160) Sep 2, 2024
espzav
espzav approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@100312dog Thank you for this change. LGTM

@espzav
Copy link
Collaborator

espzav commented Sep 18, 2024

@100312dog Please, don't forget bump the version of the component.

@100312dog
Copy link
Author

@100312dog Please, don't forget bump the version of the component.

I just bump the version to 1.0.5~3, is this version ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espzav espzav espzav approved these changes

Assignees
No one assigned
Labels
Component: esp_jpeg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@100312dog @CLAassistant @espzav @anastasia-be