various build fixes #378
Merged
various build fixes #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahavirj
approved these changes
Sep 17, 2024
igrr
commented
Sep 17, 2024
suda-morris
approved these changes
Sep 18, 2024
tore-espressif
approved these changes
Sep 18, 2024
actions/checkout, actions/upload-artifact, actions/download-artifact
Fixes inability to run node due to higher glibcxx version requirement: /__e/node20/bin/node: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /__e/node20/bin/node)
IDF has started detecting sections generated when compiling with -fPIC and reports that as an error. We were already passing b_staticpic=false to Meson, however turns out this had no effect, because Meson always turns on fPIC when building for android platform, and we have been setting platform to "android" in our cross_file.txt. After digging a bit, it seems that the choice of "android" platform was a hack to bypass pthread library detection which Thorvg does for other platforms, but skips for android and windows. This commit changes cross_file.txt to contain the absolute path of the directory where libpthread.a is built, so now thorvg can correctly detect pthread, and there is no need to pretend that we are building for android anymore. This commit also refactors the way cross_file.txt is generated: - started using a template in cross_file.txt.in, to be able to expand generator expressions using file(GENERATE) - replaced manual list concatenation with list(JOIN) - removed "replace_tool_name" since all the absolute tool paths are already known
igrr
force-pushed
the
bugfix/various_pipeline_fixes
branch
from
11b583b
to
83ac6d6
Compare
|
Thanks all for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI pipeline for master is failing for several reasons, this PR attempts to make it green again:
v2artifacts actions are not supported anymore and the jobs using them fail (example). In this PR all the actions are upgraded to v4.node, which has higher version libc++ dependency (example failure). In this PR, the image used for target tests is upgraded frompython:3.7-bustertopython:3.11-bookworm.coapcomponent got broken after the recent update of LWIP to 2.2.0 in ESP-IDF. This PR fixes macro redefinition by checking LWIP version first. Component version is bumped.spi_nand_flashcomponent got broken after the recent update to GCC 14 in ESP-IDF. Fixed by correcting the order of arguments tocalloc. Bumped the version.esp32_camera(indirect dependency of esp_jpeg example) got broken by GCC 14 update for the same reason. Fixed in fix: correct calloc call arguments order esp32-camera#683.thorvgcomponent got broken after IDF started detecting stray .got/.plt sections. Turns out we were not properly disabling -fPIC when building thorvg. Fixing that resulted in rewriting most of thorvg component's CMakeLists, see the commit message for more details. Bumped the component version, as well.