Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(thorvg): exclude some folders to reduce component size #380

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

igrr
Copy link
Member

@igrr igrr commented Sep 18, 2024

https://github.com/espressif/idf-extra-components/actions/runs/10919154946/job/30306218942?pr=377 — thorvg component archive size is 80 MB, and the upload process times out.

This PR excludes some of the component directories, reducing the archive size to 1.4 MB.

Testing:

  • ran compote component upload --name thorvg --namespace espressif --dry-run
  • unpacked the component archive in dist directory and built the example from it

Component version not bumped because the upload after the previous bump wasn't successful.

@igrr
Copy link
Member Author

igrr commented Sep 18, 2024

@suda-morris @espressif2022 PTAL

Copy link

Unit Test Results

  15 files    15 suites   20m 53s ⏱️
  27 tests   27 ✔️ 0 💤 0
395 runs  395 ✔️ 0 💤 0

Results for commit 0116ce7.

@igrr igrr merged commit f16d432 into master Sep 18, 2024
73 checks passed
@igrr igrr deleted the bugfix/thorvg_component_size branch September 19, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants