Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update SDK constraints and upgrade deps #1683

Merged
merged 16 commits into from
Feb 27, 2025

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Feb 5, 2025

Changes

  1. package:mews_pedantic was upgraded from ^0.26.0 to ^0.27.0 to match the DCM version (v1.17.0). (See changelog)
  2. SDK constraints were updated from >=2.x.0 <3.0.0 to ^3.0.0 since package:mews_pedantic implied. (See versions)
  3. package:analyzer was constrained to >=5.4.0 <8.0.0 since the SDK constraint implied and no breaking changes to *Element classes within the usages of packages (see versions). Some usages are deprecated and this request ignores them until we rebased to the next major version.
  4. package:source_gen was constrained to ">=1.4.0 <3.0.0" since the SDK constraint implied and no breaking changes within the usages of packages. (See versions)
  5. package:source_helper was upgraded to "^1.3.4" since the SDK constraint implied. (See versions)
  6. package:solana now allows package:decimal v3 to be resolved.
  7. package:melos was upgraded from 3.0.0 to 6.3.2.
  8. Regenerate files since dependencies were upgraded.

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@AlexV525 AlexV525 requested a review from ookami-kb as a code owner February 5, 2025 15:24
@ookami-kb
Copy link
Collaborator

package:melos can be resolved as any version since the repo has no code usage to the package.

No, melos should have constraints as well. There can be breaking changes between versions, it's not that different from any other dependency in this case.

@AlexV525

This comment was marked as off-topic.

@AlexV525 AlexV525 changed the title feat: Update SDK constraints and allows package:decimal v3 feat: Update SDK constraints and upgrade deps Feb 6, 2025
@AlexV525 AlexV525 force-pushed the feat/deps-constraints branch from defa6f8 to 49244ff Compare February 6, 2025 03:03
@AlexV525
Copy link
Contributor Author

AlexV525 commented Feb 6, 2025

So...I've also upgraded dependencies according to the constraint update, and all generated files are regenerated. I appreciate your input about this big change and will follow up if you want to separate these changes into smaller requests.

@AlexV525
Copy link
Contributor Author

AlexV525 commented Feb 6, 2025

package:pigeon was not upgraded as I wasn't involved with integration tests and was uncertain about the affection range. That remains as a TODO. But as the SDK constraint implies, it needs to be >=14.0.1.

@AlexV525
Copy link
Contributor Author

Friendly ping @ookami-kb

ookami-kb
ookami-kb previously approved these changes Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (d5b0865) to head (b65f5d2).
Report is 162 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   77.64%   78.00%   +0.35%     
==========================================
  Files         189      189              
  Lines        4259     4192      -67     
==========================================
- Hits         3307     3270      -37     
+ Misses        952      922      -30     
Flag Coverage Δ
solana-beta 78.00% <ø> (?)
solana-stable 78.00% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ookami-kb ookami-kb self-requested a review February 12, 2025 23:55
@ookami-kb
Copy link
Collaborator

@AlexV525 build is failing.

@AlexV525
Copy link
Contributor Author

@AlexV525 build is failing.

Thanks for the trigger. I'll look into it soon.

@ookami-kb
Copy link
Collaborator

And one more thing I've noticed – for solana_mobile_client/example and solana_mobile_wallet/example, pubspec.lock files are updated with https://pub.dev replaced with https://pub.flutter-io.cn. Can you please revert the changes?

Other than that, everything LGTM, thanks for the PR!

@AlexV525
Copy link
Contributor Author

Locks are updated.

@AlexV525
Copy link
Contributor Author

The last test workflow seems failed because of a different version of Flutter. I've upgraded to 3.27.4.

@AlexV525
Copy link
Contributor Author

deprecated_member_use lints are ignored in the espressocash_app until we bump the SDK constraints in the future.

@AlexV525
Copy link
Contributor Author

The missing import package:retrofit/error_logger.dart has been added (maybe due to retrofit updates).

@ookami-kb ookami-kb merged commit 63d71dc into espresso-cash:master Feb 27, 2025
9 checks passed
@ookami-kb
Copy link
Collaborator

@AlexV525 merged, thank you!

@AlexV525 AlexV525 deleted the feat/deps-constraints branch February 27, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants