-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new fun facts to Fact list #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+200
−12
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
876cdbb
Add new facts, remove redundant ones
RKBoss6 a92f75b
Update ChangeLog
RKBoss6 d7ab3ec
Update metadata.json
RKBoss6 d674bd3
Add more facts
RKBoss6 67a9522
Update lib.js
RKBoss6 c62de22
Update lib.js
RKBoss6 67f04a5
Update lib.js
RKBoss6 bf6854c
add a comma after every fact, to replace using atob
RKBoss6 ef5718e
Reverse previous commit
RKBoss6 4f9643b
Update return value and encoded string in lib.js
RKBoss6 4bb0e47
Merge branch 'espruino:master' into funFacts
RKBoss6 f1f1ed4
Update return value and encoded data in lib.js
RKBoss6 58c0b21
Add clkinfo.js for displaying fun facts
RKBoss6 f0394a8
Update metadata description and add clkinfo module
RKBoss6 b2066ea
Update apps/textfacts/facts.txt
RKBoss6 5907a78
Remove jellyfish fact from facts.txt
RKBoss6 717ed3d
Apply suggestion from @Copilot
RKBoss6 8d29a2e
Revise facts for improved clarity and readability
RKBoss6 5f50f0a
Update apps/textfacts/metadata.json
RKBoss6 1ba6373
Update apps/textfacts/clkinfo.js
RKBoss6 2a7a159
Update apps/textfacts/facts.txt
RKBoss6 ceb6018
Update apps/textfacts/facts.txt
RKBoss6 4d47dbb
Update apps/textfacts/facts.txt
RKBoss6 34148bb
Update ChangeLog for version 0.03 enhancements
RKBoss6 fef6af4
Expand facts in facts.txt with additional information
RKBoss6 5001e09
Update apps/textfacts/facts.txt
RKBoss6 76c8e20
Update apps/textfacts/facts.txt
RKBoss6 f8b1036
Update apps/textfacts/facts.txt
RKBoss6 613dd69
Update apps/textfacts/facts.txt
RKBoss6 d07ebc4
Update apps/textfacts/facts.txt
RKBoss6 1c54fb5
Update apps/textfacts/clkinfo.js
RKBoss6 86696b5
Update apps/textfacts/facts.txt
RKBoss6 abbc2f7
Update apps/textfacts/ChangeLog
RKBoss6 0ce63d3
Update getCount function to return 317
RKBoss6 094ca82
Update README with clearer fact addition instructions
RKBoss6 f25d0a8
Fix lint warning about semicolon
gfwilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| 0.01: New Module! | ||
| 0.02: Removed many non-interesting facts | ||
| 0.03: Removed redundant facts, added many new facts and added a clkinfo to get random facts from a clock face. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| (function() { | ||
| return { | ||
| name: "Facts", | ||
| items: [ | ||
| { name : "Facts", | ||
| get : () => ({ text : "Fact", | ||
| img : atob("GBiBAB8A+D/D/DBmDDA8DLYYbbeZ7bDbDbAYDbAYDbcY7bHbjbBaDbAYDbcY7bHZjbBaDbAYDbgYPZ+Z/YHbgYA+AZ///f///4AYAA==") }), | ||
| show : function() { // shown - if running, start animation | ||
| this.emit('redraw'); | ||
| }, | ||
| hide: function(){ | ||
| // Intentionally left blank: no action needed when hiding | ||
| }, | ||
| run : function() { // tapped - cycle between start and stop | ||
| E.showPrompt(require('textsource').getRandomText().txt,{ | ||
| title: "Fun Fact", | ||
| buttons:{"Ok":true} | ||
| }).then(function(v){ | ||
| Bangle.load(); | ||
| }); | ||
| } | ||
| } | ||
| ] | ||
| }; | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,17 @@ | ||
| { "id": "textfacts", | ||
| "name": "List of Facts", | ||
| "shortName":"Facts", | ||
| "version":"0.02", | ||
| "description": "A list of 160 'facts' from Google Gemini. Provides a `textsource` module that apps can use to query a random fact.", | ||
| "version":"0.03", | ||
| "description": "A list of fun facts. Provides a `textsource` module that apps can use to query a random fact, as well as a clockInfo to see facts on your favorite clock.", | ||
| "icon": "icon.png", | ||
| "type": "module", | ||
| "tags": "", | ||
| "tags": "clkinfo", | ||
| "provides_modules" : ["textsource"], | ||
| "supports" : ["BANGLEJS2"], | ||
| "readme": "README.md", | ||
| "storage": [ | ||
| {"name":"textsource.txt","url":"facts.txt"}, | ||
| {"name":"textsource","url":"lib.js"} | ||
| {"name":"textsource","url":"lib.js"}, | ||
| {"name":"textsource.clkinfo.js","url":"clkinfo.js"} | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.