Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM #450

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ESM #450

wants to merge 6 commits into from

Conversation

brettz9
Copy link

@brettz9 brettz9 commented Mar 6, 2022

This builds on #410 in such a way as to use Rollup instead of browserify. I used browserify in that PR as it meant there were fewer changes necessary, but my intent was always to provide this here as ESM.

These are breaking changes as a result of exports (and if you're ok with the different paths I set up).

If the number of changes here are manageable, I can just close #410 , and if not, I can rebase this on #410 if it may be acceptable.

A few items to mention...

  1. In order to reduce diff noise in the PR, I didn't remove the IIFE indent in the main file. If you like I can do that as a separate PR (and which should be easy to confirm, as we can let ESLint auto-fix that.
  2. I don't imagine there is a need any longer for a browser export, as I've switched to separate entry points for browser and Node. I also haven't included a version export. Let me know if you want to remove these or ensure they still exist.
  3. I changed the exported paths to dist if that is all right; haven't updated the README yet with the new paths, as I wasn't sure you would be ok with them.

- Update: Use new SourceMapConsumer API in test
- Build: Provide browserified builds with npm package
- Travis: Drop 4, 6, 8; Add 10, 12, 14; check build
- Maintenance: Add `.editorconfig`
- Docs: Use fenced code blocks in README (for syntax highlighting)
- npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors`
- npm: Restore `optionator` to a regular dep. (used in published binary file)
- npm: Drop unused semver, minimist
- npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps.
- npm: Drop bluebird in favor of ES Promises
- npm: Use more recently maintained browserify + uglifyify
- npm: Replace linting and testing scripts in Gulpfile with npm scripts
- npm: Update package-lock version
- npm: update devDeps.
- npm: Update package-lock version
BREAKING CHANGE:

Adds `exports`

Also:
1. updates benchmark
2. fixes escodegen with missing options
3. Bumps travis versions
4. bumps devDep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant