GTFS diff : affichage tabulaire des changements #4500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbar
approved these changes
Apr 1, 2025
| |> Enum.filter(fn %{file: file} -> file == @selected_file end) | ||
| |> Enum.group_by(fn %{type: type} -> type end) | ||
| |> Map.to_list() | ||
| |> Enum.filter(fn {_, explanations} -> not Enum.empty?(explanations) > 0 end) %> |
There was a problem hiding this comment.
Suggestion éventuelle : avec le temps je trouve ça plus facile à suivre que les appels de fonctions cumulés comme ça soient fait en dehors du template (ex: une fonction à part, ou juste au dessus du template).
Pas bloquant pour autant ici.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff de #4493 se concentrant sur la mise en page des différences détaillées. Pas de nouveauté métier.
Voir #4460.