Mark --snapshot-count as deprecated in v3.6 and will be decommissioned in 3.7 #18998
Conversation
…d in v3.7 Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
snapshot_count_20241203
branch
from
ebdd53c to
8bc42d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18998 +/- ##
=======================================
Coverage 68.82% 68.83%
=======================================
Files 420 420
Lines 35621 35629 +8
=======================================
+ Hits 24517 24525 +8
+ Misses 9683 9680 -3
- Partials 1421 1424 +3 Continue to review full report in Codecov by Sentry.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| var warningsForDeprecatedFlags []string | ||
| cfg.cf.flagSet.Visit(func(f *flag.Flag) { | ||
| if msg, ok := deprecatedFlags[f.Name]; ok { | ||
| warningsForDeprecatedFlags = append(warningsForDeprecatedFlags, msg) | ||
| } | ||
| }) | ||
| if len(warningsForDeprecatedFlags) > 0 { | ||
| if lg := cfg.ec.GetLogger(); lg != nil { | ||
| for _, msg := range warningsForDeprecatedFlags { | ||
| lg.Warn(msg) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It seems that it only checks the command line flags. We should check the config file input as well. Proposed actions:
- Move this code snip into
configFromCmdLine; - add similar check in
configFromFile
Resolve #18995
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @fuweid @serathius