Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/pkg/logutil: simplify MergeOutputPaths function #19170

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

callthingsoff
Copy link
Contributor

@callthingsoff callthingsoff commented Jan 11, 2025

@k8s-ci-robot
Copy link

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (5813dce) to head (2386cd4).
Report is 2 commits behind head on main.

Additional details and impacted files

see 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19170      +/-   ##
==========================================
- Coverage   68.82%   68.81%   -0.01%     
==========================================
  Files         420      420              
  Lines       35644    35627      -17     
==========================================
- Hits        24531    24516      -15     
- Misses       9686     9690       +4     
+ Partials     1427     1421       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5813dce...2386cd4. Read the comment docs.

@callthingsoff callthingsoff force-pushed the simplify_MergeOutputPaths branch 2 times, most recently from e6bf60a to e334e85 Compare January 12, 2025 04:26
@serathius
Copy link
Member

Please consider first sending a PR to add a test before refactor. Separating tests would give more trust into changes because we would now nothing changes. Now there might be a bug/change in test that might slip.

@callthingsoff
Copy link
Contributor Author

Please consider first sending a PR to add a test before refactor. Separating tests would give more trust into changes because we would now nothing changes. Now there might be a bug/change in test that might slip.

This patch follows #19181, PTAL.

@callthingsoff callthingsoff force-pushed the simplify_MergeOutputPaths branch from 0c36ebd to 235ceb2 Compare January 13, 2025 14:30
@callthingsoff
Copy link
Contributor Author

Please consider first sending a PR to add a test before refactor. Separating tests would give more trust into changes because we would now nothing changes. Now there might be a bug/change in test that might slip.

This patch follows #19181, PTAL.

I have rebased onto main, PTAL. Thanks.

@callthingsoff callthingsoff force-pushed the simplify_MergeOutputPaths branch from 235ceb2 to 2386cd4 Compare January 14, 2025 11:59
// clone a new one; don't modify the original, in case it matters.
dup := slices.Clone(old)
slices.Sort(dup)
return slices.Compact(dup)
Copy link
Member

@serathius serathius Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the complexity, however I don't expect it number of outputs to be large. Readability should take precedence here.

@serathius
Copy link
Member

cc @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jan 14, 2025

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, callthingsoff, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b3c065a into etcd-io:main Jan 14, 2025
36 checks passed
@callthingsoff callthingsoff deleted the simplify_MergeOutputPaths branch January 14, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants