-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/pkg/logutil: simplify MergeOutputPaths function #19170
Conversation
Hi @callthingsoff. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 28 files with indirect coverage changes @@ Coverage Diff @@
## main #19170 +/- ##
==========================================
- Coverage 68.82% 68.81% -0.01%
==========================================
Files 420 420
Lines 35644 35627 -17
==========================================
- Hits 24531 24516 -15
- Misses 9686 9690 +4
+ Partials 1427 1421 -6 Continue to review full report in Codecov by Sentry.
|
e6bf60a
to
e334e85
Compare
Please consider first sending a PR to add a test before refactor. Separating tests would give more trust into changes because we would now nothing changes. Now there might be a bug/change in test that might slip. |
e334e85
to
0c36ebd
Compare
This patch follows #19181, PTAL. |
0c36ebd
to
235ceb2
Compare
I have rebased onto main, PTAL. Thanks. |
This patch follows etcd-io#19181. Signed-off-by: Jes Cok <[email protected]>
235ceb2
to
2386cd4
Compare
// clone a new one; don't modify the original, in case it matters. | ||
dup := slices.Clone(old) | ||
slices.Sort(dup) | ||
return slices.Compact(dup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the complexity, however I don't expect it number of outputs to be large. Readability should take precedence here.
cc @ahrtr |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, callthingsoff, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch follows #19181.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.