Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename migrate_command_test.go to common_test.go #19199

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 15, 2025

Extracted from #19168

cc @fuweid @serathius

@ahrtr
Copy link
Member Author

ahrtr commented Jan 15, 2025

cc @ivanvc @jmhbnz

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (ce4b4e5) to head (a908d35).
Report is 2 commits behind head on main.

Additional details and impacted files

see 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19199      +/-   ##
==========================================
+ Coverage   68.82%   68.84%   +0.01%     
==========================================
  Files         420      420              
  Lines       35627    35627              
==========================================
+ Hits        24519    24526       +7     
+ Misses       9688     9680       -8     
- Partials     1420     1421       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b4e5...a908d35. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for breaking it smaller @ahrtr.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Benjamin.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 1346f36 into etcd-io:main Jan 15, 2025
36 checks passed
@ahrtr ahrtr deleted the etcdutl_test_20250115 branch January 15, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants