Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor on RaftCluster.Recover() #19200

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 15, 2025

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (ce4b4e5) to head (8d0f165).
Report is 6 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/membership/cluster.go 88.57% <100.00%> (+0.04%) ⬆️

... and 21 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19200   +/-   ##
=======================================
  Coverage   68.82%   68.82%           
=======================================
  Files         420      420           
  Lines       35627    35629    +2     
=======================================
+ Hits        24519    24523    +4     
- Misses       9688     9694    +6     
+ Partials     1420     1412    -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b4e5...8d0f165. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 15, 2025

/test pull-etcd-integration-4-cpu-amd64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 92673d1 into etcd-io:main Jan 15, 2025
35 checks passed
@ahrtr ahrtr deleted the cluster_20250115 branch January 15, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants