Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate experimental-peer-skip-client-san-verification flag to feature gate #19225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wodeyoulai
Copy link

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wodeyoulai
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @wodeyoulai. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

// PeerSkipClientSanVerification enables to skip the verification of Subject Alternative Name (SAN) field in client certificates during peer TLS communication
// owner: @wodeyoulai
// alpha: v3.6
// main PR: https://github.com/etcd-io/etcd/pull/14120
Copy link
Contributor

@siyuanfoundation siyuanfoundation Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR is correct.
Can you find the original PR that added this flag and change the owner to that author? Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry.I've found the original author. I will update the PR with the correct owner shortly.

@siyuanfoundation
Copy link
Contributor

/ok-to-test

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (5d47d7f) to head (2da0636).
Report is 9 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/etcd.go 75.90% <100.00%> (+0.04%) ⬆️
server/etcdmain/config.go 71.79% <ø> (ø)
server/features/etcd_features.go 60.00% <ø> (ø)

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19225      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.02%     
==========================================
  Files         420      420              
  Lines       35650    35651       +1     
==========================================
- Hits        24514    24511       -3     
  Misses       9714     9714              
- Partials     1422     1426       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d47d7f...2da0636. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants