-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate experimental-peer-skip-client-san-verification flag to feature gate #19225
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wodeyoulai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wodeyoulai. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…e gate Signed-off-by: wodeyoulai <[email protected]>
server/features/etcd_features.go
Outdated
// PeerSkipClientSanVerification enables to skip the verification of Subject Alternative Name (SAN) field in client certificates during peer TLS communication | ||
// owner: @wodeyoulai | ||
// alpha: v3.6 | ||
// main PR: https://github.com/etcd-io/etcd/pull/14120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this PR is correct.
Can you find the original PR that added this flag and change the owner to that author? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry.I've found the original author. I will update the PR with the correct owner shortly.
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #19225 +/- ##
==========================================
- Coverage 68.76% 68.75% -0.02%
==========================================
Files 420 420
Lines 35650 35651 +1
==========================================
- Hits 24514 24511 -3
Misses 9714 9714
- Partials 1422 1426 +4 Continue to review full report in Codecov by Sentry.
|
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
issue #19062