-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
robustness: do not panic when parsing unknown versions. #19226
Conversation
Signed-off-by: Siyuan Zhang <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19226 +/- ##
==========================================
- Coverage 68.76% 68.74% -0.03%
==========================================
Files 420 420
Lines 35650 35650
==========================================
- Hits 24514 24506 -8
- Misses 9714 9718 +4
- Partials 1422 1426 +4 Continue to review full report in Codecov by Sentry.
|
/retest |
/cc @ahrtr @serathius |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since it's failing the workflow frequently, let me merge it for now.. |
Thanks @siyuanfoundation for the quick fix. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
To fix #19215