Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustness: do not panic when parsing unknown versions. #19226

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

siyuanfoundation
Copy link
Contributor

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (5d47d7f) to head (672ba74).
Report is 9 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19226      +/-   ##
==========================================
- Coverage   68.76%   68.74%   -0.03%     
==========================================
  Files         420      420              
  Lines       35650    35650              
==========================================
- Hits        24514    24506       -8     
- Misses       9714     9718       +4     
- Partials     1422     1426       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d47d7f...672ba74. Read the comment docs.

@siyuanfoundation
Copy link
Contributor Author

/retest

@siyuanfoundation
Copy link
Contributor Author

/cc @ahrtr @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

Since it's failing the workflow frequently, let me merge it for now..

@ahrtr ahrtr merged commit ecd7cfc into etcd-io:main Jan 17, 2025
37 checks passed
@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

Thanks @siyuanfoundation for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Flaky TestDowngradeUpgradeClusterOf3
3 participants