Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goword errors #19310

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix goword errors #19310

merged 1 commit into from
Jan 31, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 31, 2025

For some reason, the goword check has passed while the file tests/integration/embed/embed_proxy_test.go has an error in the godoc. Update it so it doesn't show the error anymore.

Running goword against this file returns:

$ goword ./tests/integration/embed/embed_proxy_test.go
./tests/integration/embed/embed_proxy_test.go.17: // The purpose of this (empty) package is too keep following test working: (godoc-export: The -> // Package embed_test?)

I found this while working on another related task.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

For some reason, the goword check has been passing while the file
`tests/integration/embed/embed_proxy_test.go` has an error in the godoc.
Update it so it doesn't show the error anymore.

Signed-off-by: Ivan Valdes <[email protected]>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (488f215) to head (c136d5a).
Report is 4 commits behind head on main.

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19310      +/-   ##
==========================================
+ Coverage   68.84%   68.86%   +0.02%     
==========================================
  Files         420      420              
  Lines       35693    35693              
==========================================
+ Hits        24572    24581       +9     
+ Misses       9705     9692      -13     
- Partials     1416     1420       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f215...c136d5a. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 51820df into etcd-io:main Jan 31, 2025
35 checks passed
@ivanvc ivanvc deleted the fix-goword-errors branch January 31, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants