chore: remove unused and deprecated func GetEffectiveNodeIdsFromWalEntries

[1911860538]

No description provided.

[k8s-ci-robot]

Hi @1911860538. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jmhbnz]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (49f34c9) to head (8ce740c).

Additional details and impacted files

Files with missing lines	Coverage Δ
server/storage/util.go	83.78% <ø> (+2.20%)	⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19458      +/-   ##
==========================================
+ Coverage   68.92%   68.97%   +0.05%     
==========================================
  Files         420      420              
  Lines       35753    35751       -2     
==========================================
+ Hits        24642    24660      +18     
+ Misses       9690     9668      -22     
- Partials     1421     1423       +2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f34c9...8ce740c. Read the comment docs.

[1911860538]

@1911860538: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-1-cpu-amd64 8ce740c link true /test pull-etcd-integration-1-cpu-amd64
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/retest

[ahrtr]

Thanks

Actually there are lots of similar cleanup to be done on main branch. I'd like to do it after we officially release v3.6.0.

• 3.6.0 is the top priority for now
• Keeping the main and release-3.6 branches as similar as possible will make cherry-picking easier.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 1911860538, ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[1911860538]

Thanks

Actually there are lots of similar cleanup to be done on main branch. I'd like to do it after we officially release v3.6.0.

• 3.6.0 is the top priority for now
• Keeping the main and release-3.6 branches as similar as possible will make cherry-picking easier.

Okay, I won't submit similar pull requests until the release of v3.6.0