Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/integration: address Go 1.24 usetesting issues #19607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 14, 2025

Description

Apply usetesting --fix ./... on tests/integration packages and enable usetesting.

Closes #19581

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (e2b37cf) to head (e098faf).
Report is 1 commits behind head on main.

Additional details and impacted files

see 152 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19607      +/-   ##
==========================================
+ Coverage   61.19%   68.76%   +7.56%     
==========================================
  Files         408      421      +13     
  Lines       34693    35855    +1162     
==========================================
+ Hits        21231    24655    +3424     
+ Misses      11852     9767    -2085     
+ Partials     1610     1433     -177     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2733667...e098faf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35 mmorel-35 force-pushed the enable/usetesting branch 2 times, most recently from aa85b72 to ec9d664 Compare March 15, 2025 08:42
@mmorel-35 mmorel-35 marked this pull request as ready for review March 15, 2025 08:42
@mmorel-35 mmorel-35 changed the title chore: enable usetesting tests/integration: address Go 1.24 usetesting issues Mar 15, 2025
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is too long. Reviewing it took me a lot of time, spread on different days. To other reviewers, it's a mechanical change from context.{Background(),TODO()} to t.Context() in the integration tests.

If we don't get more reviews, I suggest breaking this into multiple pull requests, @mmorel-35. Thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc, mmorel-35
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 19, 2025

I understand the problem and as it's not the first time I'm having this problem of size, I'll seriously need to find or build a tool to split those changes in smaller PR. Maybe splitting in commits per sub folders too ?
Another project has started to use Copilot as reviewer to help. Have you considered it already ?

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Contributor Author

/assign @wenjiaswe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Re-enable usetesting linter
4 participants