-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/integration: address Go 1.24 usetesting issues #19607
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
ccb033d
to
b78baa7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 152 files with indirect coverage changes @@ Coverage Diff @@
## main #19607 +/- ##
==========================================
+ Coverage 61.19% 68.76% +7.56%
==========================================
Files 408 421 +13
Lines 34693 35855 +1162
==========================================
+ Hits 21231 24655 +3424
+ Misses 11852 9767 -2085
+ Partials 1610 1433 -177 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
aa85b72
to
ec9d664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is too long. Reviewing it took me a lot of time, spread on different days. To other reviewers, it's a mechanical change from context.{Background(),TODO()}
to t.Context()
in the integration tests.
If we don't get more reviews, I suggest breaking this into multiple pull requests, @mmorel-35. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivanvc, mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I understand the problem and as it's not the first time I'm having this problem of size, I'll seriously need to find or build a tool to split those changes in smaller PR. Maybe splitting in commits per sub folders too ? |
ec9d664
to
f7a9be1
Compare
f7a9be1
to
535532e
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
535532e
to
e098faf
Compare
/assign @wenjiaswe |
Description
Apply
usetesting --fix ./...
on tests/integration packages and enable usetesting.Closes #19581