Skip to content

chore: use testify instead of testing in server/etcdserver #19613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: use testify instead of testing in server/etcdserver #19613

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

Description

This uses testify instead of testing for t.Fatal or t.Error calls in server/etcdserver package

Related to #18972

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (8da854d) to head (5dc69b7).
Report is 18 commits behind head on main.

Current head 5dc69b7 differs from pull request most recent head eea3dd6

Please upload reports for the commit eea3dd6 to get more accurate results.

Additional details and impacted files

see 51 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19613      +/-   ##
==========================================
+ Coverage   66.02%   68.78%   +2.75%     
==========================================
  Files         424      421       -3     
  Lines       35862    35857       -5     
==========================================
+ Hits        23679    24665     +986     
+ Misses      10774     9762    -1012     
- Partials     1409     1430      +21     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da854d...eea3dd6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35
Copy link
Contributor Author

/assign @fuweid

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please ask for approval from fuweid. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@mmorel-35: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-grpcproxy-integration-arm64 eea3dd6 link true /test pull-etcd-grpcproxy-integration-arm64
pull-etcd-coverage-report eea3dd6 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mmorel-35 mmorel-35 closed this by deleting the head repository May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants