feat: opcm zk roots

[ashitakah]

Summary

ZK_DISPUTE_GAME (game type 10) into OPCM V2's deploy and validation flows. This includes a new ZKDisputeGameConfig struct with ZK-specific parameters (absolutePrestate, verifier, maxChallengeDuration, maxProveDuration, challengerBond), plumbed through OPContractsManagerUtils.makeGameArgs and getGameImpl.

The ZK dispute game is gated behind DevFeatures.ZK_DISPUTE_GAME - it can't be enabled unless the dev feature is active and zkDisputeGameImpl is set. Deploy scripts are updated to include the ZK game config (disabled by default).

---

Changes

Contracts

File	Description
OPContractsManagerV2.sol	Adds ZK_DISPUTE_GAME to validGameTypes, validates the dev feature flag is active, and checks zkDisputeGameImpl is set
OPContractsManagerUtils.sol	Handles ZK_DISPUTE_GAME in getGameImpl() and makeGameArgs(), encoding constructor args (absolutePrestate, verifier, maxChallengeDuration, maxProveDuration, challengerBond, anchorStateRegistry, delayedWETH, l2ChainId)
OPContractsManagerContainer.sol	Adds zkDisputeGameImpl to Implementations
OPContractsManagerMigrator.sol	Clears ZK_DISPUTE_GAME implementation in DGF during migration
Types.sol	Defines ZK_DISPUTE_GAME = GameType.wrap(10)

Interfaces

File	Description
IOPContractsManagerUtils.sol	Adds ZKDisputeGameConfig struct and OPContractsManagerUtils_UnsupportedGameType error
IOPContractsManagerContainer.sol	Adds zkDisputeGameImpl to Implementations

Scripts

File	Description
Deploy.s.sol, DeployImplementations.s.sol, DeployOPChain.s.sol	Include ZK dispute game config (disabled by default)

Tests

File	Description
OPContractsManagerV2.t.sol	ZK game deploy, feature flag validation, integration with existing game types
OPContractsManagerUtils.t.sol	makeGameArgs and getGameImpl with ZK_DISPUTE_GAME
OPContractsManagerContainer.t.sol	Updated for the new zkDisputeGameImpl field

[wiz-inc-a178a98b5d]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Management Findings	-
Total	-

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[0xChin]

In Setup.sol https://github.com/defi-wonderland/optimism/blob/92cffe1036ce2cfcc3234e2827a2583d1964bda4/packages/contracts-bedrock/test/setup/Setup.sol#L276 we are missing to add the ZK_DISPUTE_GAME GameType

[ashitakah]

/ci authorize 0705b6b

[ashitakah]

We decided not to touch Go and to handle it in a separate PR, but the CI needs these changes to sync with the deployment and ensure the tests run successfully. That’s why the files were modified

[ashitakah]

/ci authorize d07250f

[0xChin]

/ci authorize 0529844

[0xChin]

/ci authorize a5d739d

[ashitakah]

There's still more work to ensure that the ZK Dispute game can be validated. The validate and validateWithOverrides functions in the standard validator contract have not been updated to check the ZK dispute game. Also note that the standard validator getGameImplementation function needs to be tweaked for the ZK dispute game.

Lastly, there should be a unit test asserting the ZK Dispute game validation path and a negative test that ensures that the path was actually tested. As an example, observe how the super DG validation errors are asserted dependent on the super feature flag -

optimism/packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol

Line 1584 in 34b6f64

bool superRoot = isDevFeatureEnabled(DevFeatures.SUPER_ROOT_GAMES_MIGRATION);

@Inphi Thank you so much for the feedback and for taking the time. We have addressed the comment and pushed the corresponding fixes in the latest commits. The only problem we encountered was related to the contract size, which has now been fully resolved. Feel free to take a look at the latest commits and let us know if everything looks good on your end!

[0xChin]

/ci authorize b169c5b

[ashitakah]

/ci authorize 4724d5e

[0xChin]

/ci authorize 6967086

[0xChin]

/ci authorize ce118ff

[0xChin]

@Inphi as Ashi said, for the refactor comment it became a bit messy and we decided to revert it. The other NIT for the refactor was addressed 👍

[Inphi]

Good to merge once @0xOneTony's comments are resolved.