op-sepolia: Add task to switch back to singlethreaded cannon. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Feb 5, 2025
mbaxter
reviewed
Feb 6, 2025
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.
ajsutton
force-pushed
the
aj/revert-cannon-mt
branch
from
ead701d to
ce7ae41
Compare
mbaxter
approved these changes
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
|
|
||
| * Set implementation for game type 0 to 0xF3CcF0C4b51D42cFe6073F0278c19A8D1900e856 in `DisputeGameFactory` 0x05F9613aDB30026FFd634f38e5C4dFd30a197Fa1: `setImplementation(0, 0xF3CcF0C4b51D42cFe6073F0278c19A8D1900e856)` | ||
| * Set implementation for game type 1 to 0xbbDBdfe37C02439764dE0e41C906e4396B5B3914 in `DisputeGameFactory` 0x05F9613aDB30026FFd634f38e5C4dFd30a197Fa1: `setImplementation(1, 0xbbDBdfe37C02439764dE0e41C906e4396B5B3914)` | ||
| <!--NEXT TASK DESCRIPTION--> |
There was a problem hiding this comment.
Suggested change
| <!--NEXT TASK DESCRIPTION--> | |
| <!--NEXT TASK DESCRIPTION--> |
Ethnical
reviewed
Feb 7, 2025
| @@ -0,0 +1,23 @@ | |||
| # ProxyAdminOwner - Set Dispute Game Implementation | |||
There was a problem hiding this comment.
I think we should add a link to the version of the contracts used (seems to be the v1.8.0-rc.4 solidity file NestedSignFromJson.s.sol.
Ethnical
reviewed
Feb 7, 2025
| In both, there are two changes: | ||
|
|
||
| * absolutePrestate() changes from `0x03b7eaa4e3cbce90381921a4b48008f4769871d64f93d113fcadca08ecee503b` to `0x03f89406817db1ed7fd8b31e13300444652cdb0b9c509a674de43483b2f83568`. | ||
| These can be verified by comparing to the values in [releases.json](https://github.com/ethereum-optimism/optimism/blob/develop/op-program/prestates/releases.json). |
There was a problem hiding this comment.
For improving readibility for signers and going faster for reviewers just added the permalink to version 1.4.0.
Suggested change
| These can be verified by comparing to the values in [releases.json](https://github.com/ethereum-optimism/optimism/blob/develop/op-program/prestates/releases.json). | |
| These can be verified by comparing to the values in [releases.json](https://github.com/ethereum-optimism/optimism/blob/be6ca32937c8cd47d08c560dde55bc68142c48cc/op-program/prestates/releases.json#L44). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add task to switch back to singlethreaded cannon.
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.