Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code comment errors #559

Closed
wants to merge 8 commits into from
Closed

fix: code comment errors #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d6a3c7
README.md
intls Feb 6, 2025
2c9d9f4
README.md
intls Feb 6, 2025
0d38335
README.md
intls Feb 6, 2025
df9a488
ProtocolVersionsBump.s.sol
intls Feb 6, 2025
ffbb7a0
Merge branch 'main' into superchain-ops-errors
intls Feb 7, 2025
0b2374f
Merge branch 'main' into superchain-ops-errors
intls Feb 8, 2025
2f623d0
Merge branch 'main' into superchain-ops-errors
intls Feb 10, 2025
8af5729
Merge branch 'main' into superchain-ops-errors
intls Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This repo contains execution code and artifacts related to superchain deployments and other tasks.

This repo is structured with each network having a high level directory which contains sub directories of any "tasks" which have occured on that network.
This repo is structured with each network having a high level directory which contains sub directories of any "tasks" which have occurred on that network.

Tasks include:

Expand Down
8 changes: 4 additions & 4 deletions script/verification/ProtocolVersionsBump.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ abstract contract ProtocolVersionsBump is VerificationBase, SuperchainRegistry {
uint32 preRelease;
}

uint256 immutable reccomended;
uint256 immutable recommended;
uint256 immutable required;

address owner;

constructor(address _owner, ProtoVer memory _recommended, ProtoVer memory _required) {
owner = _owner;
console.log("Current owner is:", owner);
reccomended = encodeProtocolVersion(_recommended);
recommended = encodeProtocolVersion(_recommended);
required = encodeProtocolVersion(_required);
console.log(
"Will validate ProtocolVersions bump to (reccommended,required): ",
Expand All @@ -31,7 +31,7 @@ abstract contract ProtocolVersionsBump is VerificationBase, SuperchainRegistry {
);
console.log(
"Encoded versions are (reccommended,required): ",
LibString.toHexString(reccomended, 32),
LibString.toHexString(recommended, 32),
LibString.toHexString(required, 32)
);
addAllowedStorageAccess(proxies.ProtocolVersions);
Expand Down Expand Up @@ -62,6 +62,6 @@ abstract contract ProtocolVersionsBump is VerificationBase, SuperchainRegistry {
ProtocolVersions pv = ProtocolVersions(proxies.ProtocolVersions);
require(pv.owner() == owner, "PV.owner not expected");
require(ProtocolVersion.unwrap(pv.required()) == required, "Required PV not set correctly");
require(ProtocolVersion.unwrap(pv.recommended()) == reccomended, "Recommended PV not set correctly");
require(ProtocolVersion.unwrap(pv.recommended()) == recommended, "Recommended PV not set correctly");
}
}
2 changes: 1 addition & 1 deletion tasks/eth/005-2-ecotone-set-gas-config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Please see the signing and execution instructions in [SINGLE.md](../../../SINGLE

### State

On the "State" tab, you can verify that the following two state changes occured on the `SystemConfigProxy` at `0x229047fed2591dbec1ef1118d64f7af3db9eb290`:
On the "State" tab, you can verify that the following two state changes occurred on the `SystemConfigProxy` at `0x229047fed2591dbec1ef1118d64f7af3db9eb290`:

* `overhead` (key `0x65`) changed from `0xbc = 188` to `0`
* `scalar` (key `0x66`) changed
Expand Down
2 changes: 1 addition & 1 deletion tasks/eth/005-3-ecotone-calldata-gas-config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Please see the signing and execution instructions in [SINGLE.md](../../../SINGLE

### State

On the "State" tab, you can verify that the following two state changes occured on the `SystemConfigProxy` at `0x229047fed2591dbec1ef1118d64f7af3db9eb290`:
On the "State" tab, you can verify that the following two state changes occurred on the `SystemConfigProxy` at `0x229047fed2591dbec1ef1118d64f7af3db9eb290`:

* `overhead` (key `0x65`) changed from `0xbc = 188` to `0`.
This state diff will only be there before execution of task `005-2`, which itself sets this to `0` already.
Expand Down