Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7612: Add test cases for EIP-7612 overlay tree #9473

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

VolodymyrBg
Copy link
Contributor

This pull request adds comprehensive test cases to EIP-7612 (Verkle state transition via an overlay tree). The test cases cover the core functionality of the overlay tree mechanism:

  • Reading from MPT when data is not in VKT
  • Writing to VKT and reading back
  • Creating new accounts in VKT
  • Storage slot operations
  • Code storage and retrieval
  • Block header state root verification
    These test cases provide clear guidance for implementers to verify their overlay tree implementations and ensure compatibility across different Ethereum clients. The test cases follow a consistent format with setup, actions, and expected outcomes for each scenario.

@VolodymyrBg VolodymyrBg requested a review from eth-bot as a code owner March 11, 2025 16:01
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Mar 11, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 11, 2025

File EIPS/eip-7612.md

Requires 1 more reviewers from @adietrichs, @gabrocheleau, @gballet, @GottfriedHerold, @jlokier, @jsign, @matkt, @parithosh, @tanishqjasoria

@eth-bot eth-bot added the a-review Waiting on author to review label Mar 11, 2025
Copy link

The commit 207e2fa (as a parent of d2e69ae) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 11, 2025
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 11, 2025
@matkt
Copy link

matkt commented Mar 11, 2025

Do we also want to add reorg test cases before finalization?

  • We go from PMT to verkle
  • Reorg from verkle to PMT
  • Then we import new PMT blocks
  • Switch to verkle again

@VolodymyrBg
Copy link
Contributor Author

@matkt Corrected. Hope now it looks alright

@VolodymyrBg
Copy link
Contributor Author

@jsign could you check it please when you have a free moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants