Skip to content

Conversation

@pettinarip
Copy link
Member

@pettinarip pettinarip commented Sep 19, 2025

Description

With the recent introduction of the virtualized list (#16233), the native browser search (Ctrl+F) no longer works as expected. Items that are not currently visible are unmounted, so they cannot be found via the search.

This PR mitigates the issue by rendering “ghost” elements containing wallet names. This way, all wallet names remain discoverable with the native search. When matched, the user can scroll to the approximate position of the wallet. While not pixel-perfect, this at least ensures that users can locate wallets using the browser’s search functionality.

TODO

If it works, move the ghost list to its own component and memo it to avoid perf impact.

@netlify
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1c6e454
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68cd3cc7e5b0c90008c08622
😎 Deploy Preview https://deploy-preview-16311--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 6 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 20, 2025
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 20, 2025
@wackerow
Copy link
Member

Hey @pettinarip, curious how you want to move forward with this... as we discussed, this doesn't perfectly target the location of the wallet, but it does at least get spotted by a browser "Find" search, which is arguably better than now, since the user will at least know that the wallet is on the page somewhere. I'd be down to move forward as-is and iterate from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants