cleanup: remove unused loading state from GasPriceDisplay #16487
+0
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeemmmmmm
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
❌ Deploy Preview for ethereumorg failed.
|
wackerow
reviewed
Oct 14, 2025
There was a problem hiding this comment.
Hey @eeemmmmmm.. I'm not even seeing this on the page—this page is effectively in archive-mode at this point, with no further minting possible. If we're going to make any changes I'd suggest removing this entirely.
|
Ah, to remove this we'll need to adjust more than just this component though.. cc: @corwintines any reason you see to keep this, or can we proceed to take out the stuff that was used for the 10-year anniversary? |
|
@wackerow down to just clean up the 10 year page in this PR and clean out whatever isn't in use anymore. |
|
Going to close this one out for now, but we can set up a separate task to clean up the 10 year page, removing all the pieces that are no longer needed.. thanks folks! |
github-actions
bot
added
the
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Strip the unused loading flag so the component always renders the current gas level label