remove unevaluatedProperties #537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting this error when using this schema and ajv. `unevaluatedProperties` is part of json schema 2019, we shouldn't use it in an [OpenRPC document since it uses JSON Schema 07](https://spec.open-rpc.org/#meta-json-schema) `strict mode: unknown keyword: "unevaluatedProperties"`
|
The original discussion is here: #435 (comment) I also noted that it was not available in draft 07, but didn't realize that was a strict requirement for OpenRPC. Seems like we should remove it, but it appears there is an issue with schema if we directly accept this PR: https://www.jsonschemavalidator.net/s/pGB6o5eO Any idea how to keep the schema strict here, but still remove this value? |
|
if I remove the stuff inline with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting this error when using this JSON Schema and
ajv.unevaluatedPropertiesis part of JSON Schema 2019, we shouldn't use it anyways in an OpenRPC document since the spec points out using JSON Schema 07.strict mode: unknown keyword: "unevaluatedProperties"are we sure we need
unevaluatedPropertieshere?