-
Notifications
You must be signed in to change notification settings - Fork 133
Convert to Prague intrinsic gas test #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hi @winsvega , is this issue still open |
Yes. Some logic is partially covered in pyspecs. But it's worth to reimplement original Ori's logic in .py |
I converted first 2 tests into .py, now we can support it on Prague if we adjust the formula |
shall be covered here: #1535 |
Lets get this in for the final prague release. |
PR merged 💯 |
This vector:
is no longer can be supported on Prague. we need to convert it to .py or verify that existing .py tests already cover this case
https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stEIP1559/intrinsicFiller.yml
https://github.com/ethereum/tests/blob/develop/src/BlockchainTestsFiller/InvalidBlocks/bcEIP1559/intrinsicOrFailFiller.yml
I put the issue here because I disable this test for Prague in ethereum/tests
it is too difficult to make a Prague version of it in json format so it worth to reimplement it in python directly.
related test:
The text was updated successfully, but these errors were encountered: