Skip to content

Convert to Prague intrinsic gas test #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
Tracked by #1508
winsvega opened this issue Feb 10, 2025 · 6 comments
Closed
5 tasks done
Tracked by #1508

Convert to Prague intrinsic gas test #1199

winsvega opened this issue Feb 10, 2025 · 6 comments
Labels
fork:prague Prague hardfork good first issue Good for newcomers port Related to porting ethereum/tests to EEST

Comments

@winsvega
Copy link
Contributor

winsvega commented Feb 10, 2025

This vector:

is no longer can be supported on Prague. we need to convert it to .py or verify that existing .py tests already cover this case

I put the issue here because I disable this test for Prague in ethereum/tests
it is too difficult to make a Prague version of it in json format so it worth to reimplement it in python directly.

related test:

@winsvega winsvega added good first issue Good for newcomers port Related to porting ethereum/tests to EEST fork:prague Prague hardfork labels Feb 10, 2025
@anushkasomani
Copy link

hi @winsvega , is this issue still open

@winsvega
Copy link
Contributor Author

Yes.

Some logic is partially covered in pyspecs. But it's worth to reimplement original Ori's logic in .py

@winsvega
Copy link
Contributor Author

winsvega commented May 5, 2025

I converted first 2 tests into .py, now we can support it on Prague if we adjust the formula
Note: ori did some base fee interaction variation of this test. that need to convert separate in london fork

@winsvega
Copy link
Contributor Author

winsvega commented May 6, 2025

shall be covered here: #1535

@spencer-tb
Copy link
Contributor

shall be covered here: #1535

Lets get this in for the final prague release.

@marioevz
Copy link
Member

PR merged 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork good first issue Good for newcomers port Related to porting ethereum/tests to EEST
Projects
None yet
Development

No branches or pull requests

4 participants