feat(tests): port intrinsic transaction gas tests from Ori #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
force-pushed
the
intrinsicgen
branch
2 times, most recently
from
1049a46 to
2713f01
Compare
winsvega
added
scope:tests
marioevz
reviewed
May 5, 2025
8 tasks
|
with this PR it can measure the coverage diff of blockchain converted tests as well |
|
coverage state revert is lost, but that's not the point of the test. |
5 tasks
marioevz
approved these changes
May 7, 2025
|
Some more bc tests can be romved now. |
|
Interestingly, with #1554, the base blockchain tests from ethereum/tests are failing for evmone: https://github.com/ethereum/execution-spec-tests/actions/runs/14888483032/job/41814347440?pr=1535 |
15 tasks
|
@winsvega should it be ok to merge this with the failing coverage? |
|
Yes, I can trigger coverage rerun once evmone implementation is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This combination tests are failing in Prague, I port it now as it can not be adjusted in .json tests. (the filler was removed in ethereum/tests)
So now we can easily switch formula calculation in python.
TODO
🔗 Related Issues
#1199
ethereum/tests#1488
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.