-
Notifications
You must be signed in to change notification settings - Fork 144
chore(tests): small additional eip2935 transition fork edge cases #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EELS is failing to fill these tests for me with:
Looking into it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks!
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Outdated
Show resolved
Hide resolved
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Show resolved
Hide resolved
…lock_hashes.py Co-authored-by: Mario Vega <[email protected]>
@spencer-tb I think we should no longer merge this, this test only applies at the transition to Prague, which was tested during all our testnets, so filling two other 8000+ block tests would be IMO too much. Wdyt? |
SGTM! Closing! |
🗒️ Description
Adds 2 additional cases that cover a covariant of one a missing TODO for EIP-2935. The other TODO was covered already.
🔗 Related Issues
N/A.
✅ Checklist