Skip to content

chore(tests): small additional eip2935 transition fork edge cases #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Apr 15, 2025

🗒️ Description

Adds 2 additional cases that cover a covariant of one a missing TODO for EIP-2935. The other TODO was covered already.

🔗 Related Issues

N/A.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:prague Prague hardfork labels Apr 15, 2025
@spencer-tb spencer-tb self-assigned this Apr 15, 2025
@spencer-tb
Copy link
Contributor Author

EELS is failing to fill these tests for me with:

local - - [16/Apr/2025 09:20:59] code 501, message Unsupported method ('GET')                                                                                                                                                                                                                                                       
----------------------------------------                                                                                                                                                                                                                                                                                            
Exception occurred during processing of request from ['local', 0]                                                                                                                                                                                                                                                                   
Traceback (most recent call last):                                                                                                                                                                                                                                                                                                  
  File "/home/spencer-tb/execution-spec-tests/.venv/lib/python3.12/site-packages/requests/models.py", line 963, in json                                                                                                                                                                                                             
    return complexjson.loads(self.content.decode(encoding), **kwargs)                                                                                                                                                                                                                                                               
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                               
  File "/usr/local/lib/python3.12/json/__init__.py", line 346, in loads                                                                                                                                                                                                                                                             
    return _default_decoder.decode(s)                                                                                                                                                                                                                                                                                               
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                                                               
  File "/usr/local/lib/python3.12/json/decoder.py", line 337, in decode                                                                                                                                                                                                                                                             
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())                                                                                                                                                                                                                                                                               
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                                               
  File "/usr/local/lib/python3.12/json/decoder.py", line 353, in raw_decode                                                                                                                                                                                                                                                         
    obj, end = self.scan_once(s, idx)                                                                                                                                                                                                                                                                                               
               ^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                                                               
json.decoder.JSONDecodeError: Unterminated string starting at: line 7069 column 21 (char 245336748)                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                                                                    
During handling of the above exception, another exception occurred:                                                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                                                                    
Traceback (most recent call last):                                                                                                                                                                                                                                                                                                  
  File "/usr/local/lib/python3.12/socketserver.py", line 318, in _handle_request_noblock                                                                                                                                                                                                                                            
    self.process_request(request, client_address)                                                                                                                                                                                                                                                                                   
  File "/usr/local/lib/python3.12/socketserver.py", line 349, in process_request                                                                                                                                                                                                                                                    
    self.finish_request(request, client_address)                                                                                                                                                                                                                                                                                    
  File "/home/spencer-tb/execution-spec-tests/.venv/lib/python3.12/site-packages/ethereum_spec_evm_resolver/daemon.py", line 90, in finish_request                                                                                                                                                                                  
    super().finish_request(request, client_address)                                                                                                                                                                                                                                                                                 
  File "/usr/local/lib/python3.12/socketserver.py", line 362, in finish_request                                                                                                                                                                                                                                                     
    self.RequestHandlerClass(request, client_address, self)                                                                                                                                                                                                                                                                         
  File "/usr/local/lib/python3.12/socketserver.py", line 761, in __init__                                                                                                                                                                                                                                                           
    self.handle()                                                                                                                                                                                                                                                                                                                   
  File "/usr/local/lib/python3.12/http/server.py", line 436, in handle                                                                                                                                                                                                                                                              
    self.handle_one_request()                                                                                                                                                                                                                                                                                                       
  File "/usr/local/lib/python3.12/http/server.py", line 424, in handle_one_request                                                                                                                                                                                                                                                  
    method()                                                                                                                                                                                                                                                                                                                        
  File "/home/spencer-tb/execution-spec-tests/.venv/lib/python3.12/site-packages/ethereum_spec_evm_resolver/daemon.py", line 54, in do_POST                                                                                                                                                                                         
    response_json = response.json()                                                                                                                                                                                                                                                                                                 
                    ^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                                                                 
  File "/home/spencer-tb/execution-spec-tests/.venv/lib/python3.12/site-packages/requests/models.py", line 971, in json                                                                                                                                                                                                             
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)                                                                                                                                                                                                                                                                              
requests.exceptions.JSONDecodeError: Unterminated string starting at: line 7069 column 21 (char 245336748)                                                                                                                                                                                                                          
----------------------------------------  

Looking into it!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks!

@marioevz
Copy link
Member

marioevz commented May 9, 2025

@spencer-tb I think we should no longer merge this, this test only applies at the transition to Prague, which was tested during all our testnets, so filling two other 8000+ block tests would be IMO too much. Wdyt?

@spencer-tb
Copy link
Contributor Author

SGTM! Closing!

@spencer-tb spencer-tb closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants