-
Notifications
You must be signed in to change notification settings - Fork 185
test: add max block size test using access lists #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add max block size test using access lists #1932
Conversation
Add test_block_full_access_list_and_data to test maximum block size by splitting gas between access lists (60%) and calldata (40%). Uses 1 address with many storage keys to maximize block size.
|
Nice work! I am just curious why the ratio is |
|
This is because under EIP-7623, you only hit the floor price for calldata if you use <60% of the available gas for EVM execution. Now, because we treat ALs as "storage access", they also contribute to the EVM part for calldata pricing. Thus, the max possible block size (snappy compresses) is the one I got in the test case. Added it in the last commit here. |
|
Thanks for your detailed explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the test! A couple of comments, and I'll be happy to assist in the changes if you need it to get it merged 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…#1932) * test: add max block size test using access lists Add test_block_full_access_list_and_data to test maximum block size by splitting gas between access lists (60%) and calldata (40%). Uses 1 address with many storage keys to maximize block size. * Increase block size even further * integrate suggested changes * Update tests/benchmark/test_worst_blocks.py * Update tests/benchmark/test_worst_blocks.py --------- Co-authored-by: Mario Vega <[email protected]>

Add test_block_full_access_list_and_data to test maximum block size by splitting gas between access lists (60%) and calldata (40%). Uses 1 address with many storage keys to maximize block size.
🗒️ Description
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.