-
Notifications
You must be signed in to change notification settings - Fork 183
feat(benchmark): add SLOAD/SSTORE benchmark test with multi-contract support #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CPerezz
wants to merge
9
commits into
ethereum:main
Choose a base branch
from
CPerezz:feat/bloatnet-sload-sstore-benchmarks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5a1a966
feat(benchmark): add SLOAD benchmark test with multi-contract support
CPerezz 4843bc3
feat(benchmark): add SSTORE benchmark test using ERC20 approve
CPerezz 5834cc6
fix(benchmark): correct SSTORE benchmark gas calculation
CPerezz b0a7aa0
feat(benchmark): add mixed SLOAD/SSTORE benchmark with configurable r…
CPerezz 552638e
refactor(benchmark): optimize SLOAD/SSTORE benchmarks per review feed…
CPerezz 91c6ebb
refactor(benchmark): simplify SLOAD benchmark memory layout and fix c…
CPerezz 07764be
refactor(benchmark): simplify SSTORE benchmark memory layout and fix …
CPerezz abcdde8
refactor(benchmark): simplify mixed SLOAD/SSTORE memory layout and fi…
CPerezz 1902c2a
refactor(benchmark): simplify mixed test to reuse memory layout consi…
CPerezz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick check: is this ERC-20 a built with minimal bytecode format? AFAIK, usual approve has more stuff (non-payable guard, event emission, ). Also, are we assuming the selector is always the first entry in the jump table?
Same issue applies to other tests:
test_mixed_sload_sstore
,test_sload_empty_erc20_balanceof
andtest_sstore_erc20_approve