Skip to content

Conversation

@SamWilsn
Copy link
Contributor

πŸ—’οΈ Description

This pull request hooks up the new fork tool to the Hardfork class, uses that integration to generate new forks when the blob parameters are changed by the tests.

πŸ”— Related Issues or PRs

closes #1453

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn SamWilsn force-pushed the dynamic-bpo branch 2 times, most recently from c0ddae7 to bfbe9d6 Compare December 3, 2025 15:11
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 83.87%. Comparing base (2b7dc12) to head (892a14f).

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1789      +/-   ##
===============================================
- Coverage        87.31%   83.87%   -3.45%     
===============================================
  Files              541      402     -139     
  Lines            32832    25101    -7731     
  Branches          3015     2285     -730     
===============================================
- Hits             28668    21053    -7615     
- Misses            3557     3609      +52     
+ Partials           607      439     -168     
Flag Coverage Ξ”
unittests 83.87% <ΓΈ> (-3.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SamWilsn SamWilsn added this to the osaka milestone Dec 3, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Just a couple small comments!

I filled all our BPO tests with this and they pass on Geth :D

Would you be happy adding this feature.yaml change, is so once merged we should create a quick patch release on top of v5.4.0? edited: added here #1845

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

FYI I am filling with:

uv run fill --from=Osaka --until=BPO4 --clean -n 4 -k BPO -v

@SamWilsn
Copy link
Contributor Author

SamWilsn commented Dec 4, 2025

@spencer-tb should I add --until BPO4 to our tox.ini?

@spencer-tb
Copy link
Contributor

@spencer-tb should I add --until BPO4 to our tox.ini?

Yes please! Totally forgot πŸ˜“

@SamWilsn
Copy link
Contributor Author

SamWilsn commented Dec 4, 2025

Done :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate ephemeral BPO test-only forks during CI fixture building

2 participants