-
Notifications
You must be signed in to change notification settings - Fork 392
bug(test-cli-fill): Use default evm-dump-dir for traces; gitignore it #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(test-cli-fill): Use default evm-dump-dir for traces; gitignore it #1852
Conversation
be310c6 to
0793283
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1852 +/- ##
===============================================
- Coverage 87.31% 83.87% -3.45%
===============================================
Files 541 402 -139
Lines 32832 25101 -7731
Branches 3015 2285 -730
===============================================
- Hits 28668 21053 -7615
- Misses 3557 3609 +52
+ Partials 607 439 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change I think should be a good optimization to make.
packages/testing/src/execution_testing/client_clis/file_utils.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/client_clis/file_utils.py
Outdated
Show resolved
Hide resolved
5f5f730 to
121186d
Compare
121186d to
70ab208
Compare
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
🗒️ Description
--traceswith--evm-dump-diris currently broken due to improperLazyAllochandling. This PR fixes it by validating withget()and properly serializing viamodel_dump_json.--evm-dump-diroftraces/which is also in.gitignoreso we don't have to keep removing it from the working dir. Previously,--tracesdid absolutely nothing without a specified--evm-dump-dirbut it also didn't tell you anything in the cli if you did this, which is quite confusing DevEx.🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture