Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Dec 5, 2025

🗒️ Description

  • --traces with --evm-dump-dir is currently broken due to improper LazyAlloc handling. This PR fixes it by validating with get() and properly serializing via model_dump_json.
  • Use a default --evm-dump-dir of traces/ which is also in .gitignore so we don't have to keep removing it from the working dir. Previously, --traces did absolutely nothing without a specified --evm-dump-dir but it also didn't tell you anything in the cli if you did this, which is quite confusing DevEx.

🔗 Related Issues or PRs

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-12-05 at 11 53 25

@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem A-test-cli-fill Area: Tests Fill CLI—runs tests and generates fixtures (eg. `p/t/s/e/cli/pytest_commands/fill.py`) labels Dec 5, 2025
@fselmo fselmo force-pushed the fix/traces-default-evm-dump-dir branch from be310c6 to 0793283 Compare December 5, 2025 19:06
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.87%. Comparing base (2a6f9ee) to head (5f21c42).
⚠️ Report is 15 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1852      +/-   ##
===============================================
- Coverage        87.31%   83.87%   -3.45%     
===============================================
  Files              541      402     -139     
  Lines            32832    25101    -7731     
  Branches          3015     2285     -730     
===============================================
- Hits             28668    21053    -7615     
- Misses            3557     3609      +52     
+ Partials           607      439     -168     
Flag Coverage Δ
unittests 83.87% <ø> (-3.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fselmo fselmo changed the title fix(test-cli-fill): Use default evm-dump-dir for traces; gitignore it bug(test-cli-fill): Use default evm-dump-dir for traces; gitignore it Dec 5, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change I think should be a good optimization to make.

fselmo added a commit to fselmo/execution-specs that referenced this pull request Dec 8, 2025
fselmo added a commit to fselmo/execution-specs that referenced this pull request Dec 8, 2025
@fselmo fselmo force-pushed the fix/traces-default-evm-dump-dir branch from 5f5f730 to 121186d Compare December 8, 2025 18:46
@fselmo fselmo force-pushed the fix/traces-default-evm-dump-dir branch from 121186d to 70ab208 Compare December 8, 2025 18:52
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fselmo fselmo merged commit 0d82be5 into ethereum:forks/osaka Dec 8, 2025
12 checks passed
@fselmo fselmo deleted the fix/traces-default-evm-dump-dir branch December 8, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-cli-fill Area: Tests Fill CLI—runs tests and generates fixtures (eg. `p/t/s/e/cli/pytest_commands/fill.py`) C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants