Skip to content

Add initial FOCIL implementation #30914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add initial FOCIL implementation #30914

wants to merge 18 commits into from

Conversation

@jihoonsong
Copy link

@jihoonsong jihoonsong commented Dec 14, 2024

This PR implements initial FOCIL specifications. For more information, please refer to EIP-7805 and this PR.

@s1na s1na self-assigned this Dec 16, 2024
lightclient
lightclient reviewed Jan 7, 2025
View reviewed changes
@jihoonsong jihoonsong force-pushed the focil branch 3 times, most recently from 33efbee to 78f8ad9 Compare January 9, 2025 08:46
@jihoonsong jihoonsong force-pushed the focil branch 2 times, most recently from 9f5db6f to bbdaa45 Compare January 19, 2025 05:36
ensi321
ensi321 reviewed Feb 7, 2025
View reviewed changes
Copy link

@ensi321 ensi321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing out Engine API has incorrect type for inclusion list. Current implementation expects base64 strings whereas the convention and the specs demand hex strings.

I suggest either define inclusion list type and its marshal type in beacon/engine/types.go and let gencodec handles the conversion similar to how ExecutableData is handled. Or manually marshal/unmarshal like how convertRequests handles incoming executionRequests in NewPayloadV4

@jihoonsong
Copy link
Author

jihoonsong commented Feb 7, 2025

I've addressed comments. Thank you very much for spotting out the issue and suggesting solutions! @ensi321

s1na
s1na reviewed Feb 21, 2025
View reviewed changes
@jihoonsong jihoonsong force-pushed the focil branch 2 times, most recently from eb46040 to d5c724b Compare February 24, 2025 16:26
Marchhill
Marchhill reviewed Feb 24, 2025
View reviewed changes
@jihoonsong jihoonsong force-pushed the focil branch 3 times, most recently from 9e1f361 to 29b805d Compare March 21, 2025 14:11
@jihoonsong jihoonsong force-pushed the focil branch 2 times, most recently from 0f57323 to 7d8f1b0 Compare July 29, 2025 11:00
@jihoonsong
Copy link
Author

jihoonsong commented Jul 29, 2025

This PR has been updated to validate inclusion list inside state_processor.go. Following @fjl's feedback, it puts IL transactions inside block similar to ExecutionWitness. Additionally, now it validates IL transactions before passing using it.

@nerolation nerolation mentioned this pull request Aug 6, 2025
Merged
@jihoonsong jihoonsong force-pushed the focil branch 2 times, most recently from dffb273 to 1a1adcd Compare August 15, 2025 12:40
@jihoonsong
Copy link
Author

jihoonsong commented Aug 15, 2025

This PR now has been updated to reflect the latest execution apis spec as of 2025-08-15. A Kurtosis config can access to the docker image via el_jmage: jihoonsg/geth-focil:1a1adcd

@s1na s1na removed their assignment Aug 27, 2025
@jihoonsong
core/types, params: add InclusionList type
1dab670
@jihoonsong
beacon/engine, eth/catalyst, miner: add GetInclusionListV1
7ce64f1
@jihoonsong
beacon/engine: add INCLUSION_LIST_UNSATISFIED to engine API errors
3e487c0
@jihoonsong
params: support eip7805 fork
d03a817
@jihoonsong
eth/catalyst: make forkchoiceUpdatedV3 and newPayloadV4 available…
169d4a0 
… on eip7805 fork
@jihoonsong
eth/catalyst: add engine_newPayloadV5
1986e81
@jihoonsong
beacon/engine, core, eth/catalyst: verify if a block satisfies the in…
dffe6d3 
…clusion list constraints
@jihoonsong
eth/catalyst: add an unit test for verifying new payload against incl…
ed28133 
…usion list
@jihoonsong
miner: add inclusionList to BuildPayloadArgs and generateParams
3111ae8
@jihoonsong
miner: add inclusionListTxs to environment
8ddd60a
@jihoonsong
miner: include inclusion list transactions when building a payload
526baf2
@jihoonsong
miner: add a public method to notify the inclusion list to payload
8b1cf69
@jihoonsong
eth/catalyst: add peek method to payloadQueue to return `Miner.Pa…
4ef576d 
…yload`
@jihoonsong
beacon/engine, eth/catalyst, miner: add engine_forkchoiceUpdatedV4
5d97794
@jihoonsong
eth/catalyst: add engine_forkchoiceUpdatedWithWitnessV4
c146cf4
@jihoonsong
eth/catalyst: modify getPayloadV5 to accept PayloadV4
358685b
@jihoonsong
eth/catalyst: add an unit test for updating payload with inclusion list
508ba1b
@jihoonsong
beacon/engine, eth/catalyst: return UnknownParent error when parent d…
9d17826 
…oesn't exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1na s1na s1na left review comments

@jwasinger jwasinger jwasinger left review comments

@lightclient lightclient lightclient left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@holiman holiman Awaiting requested review from holiman

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@karalabe karalabe Awaiting requested review from karalabe

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

+2 more reviewers

@Marchhill Marchhill Marchhill left review comments

@ensi321 ensi321 ensi321 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jihoonsong @jwasinger @s1na @Marchhill @lightclient @MariusVanDerWijden @ensi321