core,miner: implement EIP-7934 - RLP Execution Block Size Limit #31990
Conversation
jwasinger
requested review from
fjl,
karalabe,
gballet,
rjl493456442,
zsfelfoldi and
MariusVanDerWijden
as code owners
miner/worker.go
Outdated
There was a problem hiding this comment.
Also, the block body size is also influenced by other things, such as withdrawals. So we need to add a bit of buffer into the size limit here. For the withdrawals, we may be able to add their true size into env.size before adding transactions.
miner/worker.go
Outdated
There was a problem hiding this comment.
From the CL team:
potuz — 2025/6/10 21:11
This makes the payload invalid
Technically it will make the consensus block that contains that payload invalid.
Probably we need to put a note here, at least adding a warning log that a part of withdrawals specified by the CL are discarded due to the size restriction. In practice, it's impossible to occur.
There was a problem hiding this comment.
This happens before we fill the block with txs. Also, max block withdrawal count is capped by the protocol.
fjl
changed the title
|
I have made two changes:
|
…ts and constant deduplication.
…if we would hit the size cap when filling it with txs
…ribute to the RLP-encoded block
…t to add when creating a block
| // The tx had a sidecar before, so we need to subtract it from the size. | ||
| scSize := rlp.ListSize(blobtx.Sidecar.encodedSize()) | ||
| cpy.size.Store(size - scSize) | ||
| } |
There was a problem hiding this comment.
I've been verifying this, and this part is correct, but the Size method has some issues related with the new sidecar v2. I was thinking about fixing it in this PR before merging, but will separate this out.
…reum#31990) This PR adds a block validation check for the maximum block size, as required by EIP-7934, and also applies a slightly lower size limit during block building. --------- Co-authored-by: spencer-tb <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Gary Rong <[email protected]>
…reum#31990) This PR adds a block validation check for the maximum block size, as required by EIP-7934, and also applies a slightly lower size limit during block building. --------- Co-authored-by: spencer-tb <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Gary Rong <[email protected]>
This PR adds a check against the maximum block size, as required by EIP-7934, and also applies a slightly lower
size limit during block building.